https://git.drupal.org/sandbox/luukyb/2743227.git

Review of the 8.x-1.x branch (commit 88c9aba):

  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: ...pareviewsh/pareview_temp/src/Controller/WidendamSearchController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
    21 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    22 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    --------------------------------------------------------------------------

    FILE: ...s/pareviewsh/pareview_temp/src/Controller/WidendamAuthController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
    22 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    23 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    65 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    --------------------------------------------------------------------------

    FILE: /root/repos/pareviewsh/pareview_temp/src/Form/AdminForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
    --------------------------------------------------------------------------
    40 | WARNING | t() calls should be avoided in classes, use dependency
    | | injection and $this->t() instead
    42 | WARNING | t() calls should be avoided in classes, use dependency
    | | injection and $this->t() instead
    89 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    94 | WARNING | t() calls should be avoided in classes, use dependency
    | | injection and $this->t() instead
    100 | WARNING | t() calls should be avoided in classes, use dependency
    | | injection and $this->t() instead
    --------------------------------------------------------------------------

    Time: 39ms; Memory: 4Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.