https://git.drupal.org/project/contest.git 7.x-1.x

Review of the 7.x-1.x branch (commit 6cb1f73):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).

    /root/repos/pareviewsh/pareview_temp/js/contest.js: line 51, col 2, Error - Use the function form of 'use strict'. (strict)
    /root/repos/pareviewsh/pareview_temp/js/contest.js: line 51, col 10, Error - Missing space before function parentheses. (space-before-function-paren)
    /root/repos/pareviewsh/pareview_temp/js/contest.js: line 107, col 3, Warning - Missing JSDoc @return for function. (valid-jsdoc)

    3 problems

  • DrupalSecure has found some issues with your code (please check the Writing secure core handbook).

    FILE: .../repos/pareviewsh/pareview_temp/templates/contest-admin-page.tpl.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
    60 | ERROR | Printing unsanitized input from node title
    --------------------------------------------------------------------------

    Time: 255ms; Memory: 20Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: .../repos/pareviewsh/pareview_temp/templates/contest-admin-page.tpl.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
51 | ERROR | [x] Doc comment long description must end with a full
| | stop
142 | WARNING | [ ] Code after CONTINUE statement cannot be executed
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/contest.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
1534 | ERROR | [x] Case breaking statements must be followed by a single
| | blank line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 334ms; Memory: 22Mb