https://git.drupal.org/project/contest.git 7.x-1.x

Git errors:

Review of the 7.x-1.x branch (commit cc56506):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalSecure has found some issues with your code (please check the Writing secure core handbook).

    FILE: .../repos/pareviewsh/pareview_temp/templates/contest-admin-page.tpl.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
    60 | ERROR | Printing unsanitized input from node title
    --------------------------------------------------------------------------

    Time: 249ms; Memory: 14Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: .../repos/pareviewsh/pareview_temp/templates/contest-admin-page.tpl.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
142 | WARNING | Code after CONTINUE statement cannot be executed
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/ContestData.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
24 | ERROR | If the line declaring an array spans longer than 80
| | characters, each element should be broken into its own
| | line
112 | ERROR | If the line declaring an array spans longer than 80
| | characters, each element should be broken into its own
| | line
--------------------------------------------------------------------------

Time: 413ms; Memory: 16Mb