https://git.drupal.org/project/autopost_social.git

Git errors:

Review of the 8.x-1.x branch (commit 144a45e):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: ...iewsh/pareview_temp/src/Controller/GenerateAccessTokenController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
    --------------------------------------------------------------------------
    31 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    38 | WARNING | t() calls should be avoided in classes, use dependency
    | | injection and $this->t() instead
    50 | WARNING | t() calls should be avoided in classes, use dependency
    | | injection and $this->t() instead
    63 | WARNING | t() calls should be avoided in classes, use dependency
    | | injection and $this->t() instead
    86 | WARNING | t() calls should be avoided in classes, use dependency
    | | injection and $this->t() instead
    --------------------------------------------------------------------------

    FILE: ...oot/repos/pareviewsh/pareview_temp/src/Form/AutoPostSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
    47 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    60 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    --------------------------------------------------------------------------

    Time: 58ms; Memory: 6Mb

  • Codespell has found some spelling errors in your code.

    ./README.md:45: automaticly ==> automatically
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /root/repos/pareviewsh/pareview_temp/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
----------------------------------------------------------------------
13 | WARNING | Line exceeds 80 characters; contains 121 characters
36 | WARNING | Line exceeds 80 characters; contains 112 characters
37 | WARNING | Line exceeds 80 characters; contains 101 characters
38 | WARNING | Line exceeds 80 characters; contains 96 characters
44 | WARNING | Line exceeds 80 characters; contains 126 characters
45 | WARNING | Line exceeds 80 characters; contains 123 characters
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/autopost_social.routing.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
15 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/autopost_social.module
--------------------------------------------------------------------------
FOUND 20 ERRORS AFFECTING 18 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
| | line
7 | ERROR | [x] When importing a class with "use", do not include a
| | leading \
8 | ERROR | [x] When importing a class with "use", do not include a
| | leading \
17 | ERROR | [x] Short array syntax must be used to define arrays
20 | ERROR | [x] Short array syntax must be used to define arrays
21 | ERROR | [x] Short array syntax must be used to define arrays
25 | ERROR | [x] Short array syntax must be used to define arrays
53 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
53 | ERROR | [x] Multi-line function declarations must define one
| | parameter per line
80 | ERROR | [x] Short array syntax must be used to define arrays
86 | ERROR | [x] Short array syntax must be used to define arrays
87 | ERROR | [x] Short array syntax must be used to define arrays
91 | ERROR | [x] Short array syntax must be used to define arrays
91 | ERROR | [x] Short array syntax must be used to define arrays
99 | ERROR | [x] Short array syntax must be used to define arrays
101 | ERROR | [x] Short array syntax must be used to define arrays
145 | ERROR | [x] Short array syntax must be used to define arrays
167 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
| | 4 spaces
170 | ERROR | [x] Return comment indentation must be 3 spaces, found 4
| | spaces
179 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...iewsh/pareview_temp/src/Controller/GenerateAccessTokenController.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
8 | ERROR | [x] When importing a class with "use", do not include a
| | leading \
11 | ERROR | [x] When importing a class with "use", do not include a
| | leading \
24 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 4
| | spaces
27 | ERROR | [x] Return comment indentation must be 3 spaces, found 4
| | spaces
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/SocialPostFactory.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
3 | ERROR | [x] There must be one blank line after the namespace
| | declaration
33 | ERROR | [x] There must be no blank lines after the function comment
37 | ERROR | [x] Expected 1 space after IF keyword; 0 found
39 | ERROR | [x] Expected 1 space after IF keyword; 0 found
46 | ERROR | [x] Expected 1 blank line after function; 0 found
47 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/SocialPostBase.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
5 | ERROR | [x] When importing a class with "use", do not include a
| | leading \
36 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/SocialPostInterface.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
5 | ERROR | [x] When importing a class with "use", do not include a
| | leading \
18 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 4
| | spaces
21 | ERROR | [x] Return comment indentation must be 3 spaces, found 4
| | spaces
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...eviewsh/pareview_temp/src/Providers/Socialpost/TwitterSocialPost.php
--------------------------------------------------------------------------
FOUND 21 ERRORS AFFECTING 21 LINES
--------------------------------------------------------------------------
7 | ERROR | [x] When importing a class with "use", do not include a
| | leading \
21 | ERROR | [x] Expected "stringclientid" but found "string clientid."
| | for @var tag in member variable comment
28 | ERROR | [x] Expected "stringname" but found "string name." for
| | @var tag in member variable comment
35 | ERROR | [x] Expected "stringsecretId" but found "string secretId."
| | for @var tag in member variable comment
42 | ERROR | [x] Do not append variable name "$accessToken ." to the
| | type declaration in a member variable comment
49 | ERROR | [x] Do not append variable name "$accessToken_secret ." to
| | the type declaration in a member variable comment
73 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
| | 4 spaces
96 | ERROR | [x] Return comment indentation must be 3 spaces, found 4
| | spaces
105 | ERROR | [x] Short array syntax must be used to define arrays
110 | ERROR | [x] Short array syntax must be used to define arrays
116 | ERROR | [x] Short array syntax must be used to define arrays
121 | ERROR | [x] Short array syntax must be used to define arrays
127 | ERROR | [x] Short array syntax must be used to define arrays
135 | ERROR | [x] Short array syntax must be used to define arrays
137 | ERROR | [x] Short array syntax must be used to define arrays
144 | ERROR | [x] Short array syntax must be used to define arrays
167 | ERROR | [x] Return comment indentation must be 3 spaces, found 4
| | spaces
177 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
| | 4 spaces
187 | ERROR | [x] Return comment indentation must be 3 spaces, found 4
| | spaces
207 | ERROR | [x] Return comment indentation must be 3 spaces, found 4
| | spaces
247 | ERROR | [x] Return comment indentation must be 3 spaces, found 4
| | spaces
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 21 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...viewsh/pareview_temp/src/Providers/Socialpost/FacebookSocialPost.php
--------------------------------------------------------------------------
FOUND 23 ERRORS AFFECTING 23 LINES
--------------------------------------------------------------------------
9 | ERROR | [x] When importing a class with "use", do not include a
| | leading \
21 | ERROR | [x] Expected "stringclientid" but found "string clientid."
| | for @var tag in member variable comment
28 | ERROR | [x] Expected "stringname" but found "string name." for
| | @var tag in member variable comment
35 | ERROR | [x] Expected "stringsecretId" but found "string secretId."
| | for @var tag in member variable comment
42 | ERROR | [x] Do not append variable name "$accessToken ." to the
| | type declaration in a member variable comment
67 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
| | 4 spaces
80 | ERROR | [x] Short array syntax must be used to define arrays
96 | ERROR | [x] Return comment indentation must be 3 spaces, found 4
| | spaces
107 | ERROR | [x] Short array syntax must be used to define arrays
112 | ERROR | [x] Short array syntax must be used to define arrays
118 | ERROR | [x] Short array syntax must be used to define arrays
123 | ERROR | [x] Short array syntax must be used to define arrays
129 | ERROR | [x] Short array syntax must be used to define arrays
141 | ERROR | [x] Short array syntax must be used to define arrays
145 | ERROR | [x] Short array syntax must be used to define arrays
158 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
| | 4 spaces
161 | ERROR | [x] Return comment indentation must be 3 spaces, found 4
| | spaces
163 | ERROR | [ ] Type hint "null" missing for $code
205 | ERROR | [x] Short array syntax must be used to define arrays
234 | ERROR | [x] Return comment indentation must be 3 spaces, found 4
| | spaces
244 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
| | 4 spaces
254 | ERROR | [x] Return comment indentation must be 3 spaces, found 4
| | spaces
274 | ERROR | [x] Return comment indentation must be 3 spaces, found 4
| | spaces
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 22 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/Entity/Autopostsocial.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
49 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...ot/repos/pareviewsh/pareview_temp/src/Services/SocialPostService.php
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------
5 | ERROR | [x] When importing a class with "use", do not include a
| | leading \
9 | ERROR | [x] Expected 1 space after asterisk; 0 found
9 | ERROR | [x] Function comment short description must start with
| | exactly one space
17 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 4
| | spaces
19 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 4
| | spaces
21 | ERROR | [ ] Type hint "array" missing for $providers
28 | ERROR | [x] Expected 1 blank line after function; 2 found
31 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 141ms; Memory: 8Mb