https://git.drupal.org/project/charts.git 8.x-3.x

Git errors:

Review of the 8.x-3.x branch (commit 5a0e507):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).

    /root/repos/pareviewsh/pareview_temp/modules/charts_google/js/charts_google.js: line 24, col 49, Warning - Too many nested callbacks (4). Maximum allowed is 3. (max-nested-callbacks)
    /root/repos/pareviewsh/pareview_temp/modules/charts_google/js/charts_google.js: line 38, col 5, Error - Trailing spaces not allowed. (no-trailing-spaces)

    2 problems

  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: ...temp/modules/charts_highcharts/src/Charts/HighchartsChartsRender.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    51 | WARNING | Unused variable $key.
    --------------------------------------------------------------------------

    FILE: ...review_temp/modules/charts_highcharts/src/Plugin/chart/Highchart.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    63 | WARNING | Unused variable $key.
    --------------------------------------------------------------------------

    Time: 330ms; Memory: 10Mb

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /root/repos/pareviewsh/pareview_temp/includes/charts.pages.inc
--------------------------------------------------------------------------
FOUND 30 ERRORS AND 2 WARNINGS AFFECTING 28 LINES
--------------------------------------------------------------------------
6 | ERROR | [x] Doc comment short description must be on the first
| | line
240 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
| | 0
245 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
245 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
| | 4
246 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
| | 6
247 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
| | 4
250 | WARNING | [ ] Line exceeds 80 characters; contains 105 characters
250 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
| | 4
252 | ERROR | [x] Line indented incorrectly; expected 3 spaces, found
| | 0
302 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 16 spaces
316 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 7 spaces
324 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 15 spaces
330 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 2 spaces
359 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 19 spaces
366 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 10 spaces
434 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 11 spaces
440 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 2 spaces
472 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 20 spaces
480 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 5 spaces
503 | ERROR | [x] Equals sign not aligned with surrounding
| | assignments; expected 18 spaces but found 20 spaces
510 | ERROR | [x] Equals sign not aligned with surrounding
| | assignments; expected 9 spaces but found 11 spaces
516 | ERROR | [x] Equals sign not aligned with surrounding
| | assignments; expected 8 spaces but found 10 spaces
520 | ERROR | [x] Equals sign not aligned with surrounding
| | assignments; expected 1 space but found 3 spaces
533 | ERROR | [x] Equals sign not aligned with surrounding
| | assignments; expected 1 space but found 3 spaces
546 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 10 spaces
554 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 10 spaces
562 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 3 spaces
608 | ERROR | [ ] Type hint "array" missing for $form
608 | ERROR | [ ] Type hint "array" missing for $form_state
654 | ERROR | [ ] Type hint "array" missing for $form
654 | ERROR | [ ] Type hint "array" missing for $form_state
656 | ERROR | [x] Object operator not indented correctly; expected 4
| | spaces but found 6
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 26 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/charts.api.php
--------------------------------------------------------------------------
FOUND 13 ERRORS AFFECTING 12 LINES
--------------------------------------------------------------------------
6 | ERROR | [x] Doc comment short description must be on the first
| | line
24 | ERROR | [ ] Tags must be grouped together in a doc comment
39 | ERROR | [ ] Tags must be grouped together in a doc comment
44 | ERROR | [ ] Tags must be grouped together in a doc comment
46 | ERROR | [ ] Tags must be grouped together in a doc comment
54 | ERROR | [x] Whitespace found at end of line
60 | ERROR | [ ] Missing parameter type
62 | ERROR | [ ] Missing parameter type
81 | ERROR | [ ] Parameter tags must be defined first in a doc comment
121 | ERROR | [ ] Parameter tags must be defined first in a doc comment
121 | ERROR | [ ] Missing parameter type
157 | ERROR | [ ] Type hint "array" missing for $info
197 | ERROR | [ ] Type hint "array" missing for $chart_types
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/Util/Util.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
121 | WARNING | Only string literals should be passed to t() where
| | possible
--------------------------------------------------------------------------

FILE: ...t/repos/pareviewsh/pareview_temp/src/Plugin/chart/ChartInterface.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
26 | ERROR | [x] Expected 1 blank line after function; 0 found
27 | ERROR | [x] The closing brace for the interface must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...oot/repos/pareviewsh/pareview_temp/src/Plugin/chart/ChartManager.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
11 | ERROR | Doc comment short description must be on a single line,
| | further text should be a separate paragraph
--------------------------------------------------------------------------

FILE: ...emp/modules/charts_highcharts/src/Settings/Highcharts/Highcharts.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
90 | ERROR | [x] Line indented incorrectly; expected 3 spaces, found 0
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...review_temp/modules/charts_highcharts/src/Plugin/chart/Highchart.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
50 | ERROR | Arguments with default values must be at the end of the
| | argument list
--------------------------------------------------------------------------

FILE: ...areview_temp/modules/charts_google/src/Settings/Google/ChartAxes.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
136 | ERROR | Missing parameter type
--------------------------------------------------------------------------

FILE: ...iew_temp/modules/charts_google/src/Settings/Google/GoogleOptions.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
73 | ERROR | [x] Doc comment long description must end with a full stop
298 | ERROR | [ ] Missing parameter comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...areview_temp/modules/charts_google/src/Plugin/chart/GoogleCharts.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
37 | ERROR | Arguments with default values must be at the end of the
| | argument list
--------------------------------------------------------------------------

FILE: ...viewsh/pareview_temp/modules/charts_c3/src/Charts/C3ChartsRender.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
64 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0
64 | ERROR | [x] Whitespace found at end of line
67 | ERROR | [x] Line indented incorrectly; expected 5 spaces, found 0
74 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 0
76 | ERROR | [x] Line indented incorrectly; expected 7 spaces, found 0
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...sh/pareview_temp/modules/charts_c3/src/Plugin/chart/CThreeCharts.php
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
39 | ERROR | [ ] Arguments with default values must be at the end of the
| | argument list
74 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 0
74 | ERROR | [x] Whitespace found at end of line
77 | ERROR | [x] Line indented incorrectly; expected 5 spaces, found 0
84 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 0
84 | ERROR | [x] Whitespace found at end of line
85 | ERROR | [x] Whitespace found at end of line
86 | ERROR | [x] Line indented incorrectly; expected 7 spaces, found 0
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...ot/repos/pareviewsh/pareview_temp/modules/charts_c3/charts_c3.module
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
25 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'scatter'
33 | ERROR | [x] Expected 1 space(s) before asterisk; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 745ms; Memory: 14Mb