http://git.drupal.org/project/github_projects.git 7.x-1.x-dev

Git errors:

  • The following git branches do not match the release branch pattern, you should remove/rename them. See https://www.drupal.org/node/1015226

    * 7.x-1.x-dev
    remotes/origin/7.x-1.x-dev

Review of the 7.x-1.x-dev branch (commit ae6f1fd):

  • Remove the LICENSE, drupal.org packaging will add a LICENSE.txt file automatically.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: .../pareview_temp/src/Classes/GithubProjectsRemoteSelectQuery.class.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
    191 | WARNING | Unused variable $repository_id.
    194 | WARNING | Variable $repository_id is undefined.
    --------------------------------------------------------------------------

    FILE: ...eviewsh/pareview_temp/src/Classes/GithubProjectsConnection.class.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    13 | WARNING | Class name must be prefixed with the project name
    | | "GithubProjects"
    --------------------------------------------------------------------------

    Time: 52ms; Memory: 6Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: .../pareview_temp/src/Classes/GithubProjectsRemoteSelectQuery.class.php
--------------------------------------------------------------------------
FOUND 9 ERRORS AND 1 WARNING AFFECTING 10 LINES
--------------------------------------------------------------------------
23 | ERROR | Class property $retrieve_multiple should use lowerCamel
| | naming without underscores
27 | ERROR | Doc comment short description must be on a single line,
| | further text should be a separate paragraph
38 | ERROR | Class property $from_date should use lowerCamel naming
| | without underscores
45 | ERROR | Class property $to_date should use lowerCamel naming
| | without underscores
52 | ERROR | Class property $user_id should use lowerCamel naming
| | without underscores
56 | ERROR | Doc comment short description must be on a single line,
| | further text should be a separate paragraph
61 | WARNING | Possible useless method overriding detected
217 | ERROR | Exception type missing for @throws tag in function
| | comment
296 | ERROR | Exception type missing for @throws tag in function
| | comment
351 | ERROR | Public method name
| | "GithubProjectsRemoteSelectQuery::buildFromEFQ" is not
| | in lowerCamel format
--------------------------------------------------------------------------

FILE: ...eviewsh/pareview_temp/src/Classes/GithubProjectsConnection.class.php
--------------------------------------------------------------------------
FOUND 9 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------
13 | ERROR | Class name must begin with a capital letter
13 | ERROR | Class name must use UpperCamel naming without
| | underscores
29 | ERROR | Public method name
| | "clients_connection_our_rest::remote_entity_load" is not
| | in lowerCamel format
51 | ERROR | Public method name
| | "clients_connection_our_rest::remote_entity_save" is not
| | in lowerCamel format
51 | ERROR | Type hint "array" missing for $remote_properties
68 | ERROR | Public method name
| | "clients_connection_our_rest::entity_property_type_map"
| | is not in lowerCamel format
123 | ERROR | Type hint "array" missing for $method_params
172 | ERROR | Type hint "array" missing for $header_options
172 | ERROR | Type hint "array" missing for $data
191 | WARNING | The use of function dpm() is discouraged
--------------------------------------------------------------------------

FILE: ...oot/repos/pareviewsh/pareview_temp/src/Theme/github_projects.tpl.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/github_projects.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
279 | WARNING | The use of function dpm() is discouraged
----------------------------------------------------------------------

Time: 149ms; Memory: 8Mb