http://git.drupal.org/sandbox/somu2prl/2839832

Git errors:

Review of the 7.x-1.x branch (commit 7685428):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: /root/repos/pareviewsh/pareview_temp/commerce_fedex_freight.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
    --------------------------------------------------------------------------
    98 | WARNING | Unused variable $home_or_business.
    99 | WARNING | Unused variable $call_for_appointment.
    100 | WARNING | Unused variable $tailgate_offload.
    102 | WARNING | Unused variable $weight.
    115 | WARNING | Do not use check_plain() on string literals, because
    | | they cannot contain user provided text
    --------------------------------------------------------------------------

    FILE: ...viewsh/pareview_temp/includes/commerce_fedex_freight_rest_client.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    100 | WARNING | Unused variable $rate_class.
    --------------------------------------------------------------------------

    Time: 48ms; Memory: 6Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /root/repos/pareviewsh/pareview_temp/commerce_fedex_freight.info
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 3 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
7 | WARNING | Line exceeds 80 characters; contains 241 characters
11 | WARNING | Line exceeds 80 characters; contains 123 characters
15 | WARNING | Line exceeds 80 characters; contains 103 characters
17 | WARNING | Line exceeds 80 characters; contains 94 characters
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/commerce_fedex_freight.module
--------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one
| | blank line
25 | ERROR | [x] Expected 1 blank line after function; 2 found
96 | ERROR | [ ] Type hint "array" missing for $shipping_service
118 | ERROR | [x] Inline comments must start with a capital letter
125 | ERROR | [x] Expected 1 space before "*"; 0 found
125 | ERROR | [x] Expected 1 space after "*"; 0 found
190 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'commerce_fedex_freight_log'
192 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/commerce_fedex_freight.install
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
30 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'commerce_fedex_freight_log'
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...viewsh/pareview_temp/includes/commerce_fedex_freight_rest_client.inc
--------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------
23 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
23 | ERROR | [x] No space found before comment text; expected "//
| | $rate_class =
| | _commerce_fedex_freight_get_rate_class($order,
| | $order_wrapper);" but found "//$rate_class =
| | _commerce_fedex_freight_get_rate_class($order,
| | $order_wrapper);"
23 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing parentheses
34 | ERROR | [x] Concat operator must be surrounded by a single space
34 | ERROR | [x] Concat operator must be surrounded by a single space
52 | ERROR | [x] No space found before comment text; expected "//
| | print_r($return_obj); exit();" but found
| | "//print_r($return_obj); exit();"
65 | ERROR | [x] Expected 1 blank line after function; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...s/pareviewsh/pareview_temp/includes/commerce_fedex_freight.admin.inc
--------------------------------------------------------------------------
FOUND 5 ERRORS AND 4 WARNINGS AFFECTING 7 LINES
--------------------------------------------------------------------------
51 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
52 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
66 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
167 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
199 | ERROR | [ ] Type hint "array" missing for $form
199 | ERROR | [ ] Type hint "array" missing for $form_state
235 | ERROR | [ ] Type hint "array" missing for $form
235 | ERROR | [ ] Type hint "array" missing for $form_state
236 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
| | 4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 98ms; Memory: 8Mb