https://git.drupal.org/project/shipstation_api.git 8.x-1.x

Git errors:

Review of the 8.x-1.x branch (commit 5b105e0):

  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: /root/repos/pareviewsh/pareview_temp/src/Service/ShipStationApi.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    1100 | WARNING | Potential security problem: SSL peer verification must
    | | not be disabled
    --------------------------------------------------------------------------

    Time: 67ms; Memory: 10Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /root/repos/pareviewsh/pareview_temp/src/Service/ShipStationApi.php
-------------------------------------------------------------------------
FOUND 142 ERRORS AFFECTING 142 LINES
-------------------------------------------------------------------------
25 | ERROR | Missing @var tag in member variable comment
38 | ERROR | Missing parameter comment
56 | ERROR | Missing parameter comment
57 | ERROR | Missing parameter comment
59 | ERROR | Description for the @return value is missing
69 | ERROR | Missing parameter comment
71 | ERROR | Description for the @return value is missing
75 | ERROR | Type hint "array" missing for $params
91 | ERROR | Missing parameter comment
93 | ERROR | Description for the @return value is missing
97 | ERROR | Type hint "array" missing for $params
113 | ERROR | Missing parameter comment
115 | ERROR | Description for the @return value is missing
119 | ERROR | Type hint "array" missing for $params
135 | ERROR | Missing parameter comment
137 | ERROR | Description for the @return value is missing
141 | ERROR | Type hint "array" missing for $params
160 | ERROR | Missing parameter comment
162 | ERROR | Description for the @return value is missing
166 | ERROR | Type hint "array" missing for $params
185 | ERROR | Missing parameter comment
187 | ERROR | Description for the @return value is missing
191 | ERROR | Type hint "array" missing for $params
210 | ERROR | Missing parameter comment
212 | ERROR | Description for the @return value is missing
216 | ERROR | Type hint "array" missing for $params
232 | ERROR | Missing parameter comment
234 | ERROR | Description for the @return value is missing
238 | ERROR | Type hint "array" missing for $params
257 | ERROR | Missing parameter comment
259 | ERROR | Description for the @return value is missing
263 | ERROR | Type hint "array" missing for $params
279 | ERROR | Missing parameter comment
281 | ERROR | Description for the @return value is missing
285 | ERROR | Type hint "array" missing for $params
301 | ERROR | Missing parameter comment
303 | ERROR | Description for the @return value is missing
307 | ERROR | Type hint "array" missing for $params
323 | ERROR | Missing parameter comment
325 | ERROR | Description for the @return value is missing
329 | ERROR | Type hint "array" missing for $params
345 | ERROR | Missing parameter comment
347 | ERROR | Description for the @return value is missing
351 | ERROR | Type hint "array" missing for $params
367 | ERROR | Missing parameter comment
369 | ERROR | Description for the @return value is missing
373 | ERROR | Type hint "array" missing for $params
389 | ERROR | Missing parameter comment
391 | ERROR | Description for the @return value is missing
411 | ERROR | Missing parameter comment
413 | ERROR | Description for the @return value is missing
435 | ERROR | Missing parameter comment
436 | ERROR | Missing parameter comment
438 | ERROR | Description for the @return value is missing
442 | ERROR | Type hint "array" missing for $params
458 | ERROR | Description for the @return value is missing
478 | ERROR | Missing parameter comment
480 | ERROR | Description for the @return value is missing
484 | ERROR | Type hint "array" missing for $params
500 | ERROR | Missing parameter comment
502 | ERROR | Description for the @return value is missing
506 | ERROR | Type hint "array" missing for $params
522 | ERROR | Missing parameter comment
524 | ERROR | Description for the @return value is missing
528 | ERROR | Type hint "array" missing for $params
544 | ERROR | Missing parameter comment
546 | ERROR | Description for the @return value is missing
550 | ERROR | Type hint "array" missing for $params
566 | ERROR | Missing parameter comment
568 | ERROR | Description for the @return value is missing
572 | ERROR | Type hint "array" missing for $params
588 | ERROR | Missing parameter comment
590 | ERROR | Description for the @return value is missing
612 | ERROR | Missing parameter comment
613 | ERROR | Missing parameter comment
615 | ERROR | Description for the @return value is missing
619 | ERROR | Type hint "array" missing for $params
635 | ERROR | Missing parameter comment
637 | ERROR | Description for the @return value is missing
641 | ERROR | Type hint "array" missing for $params
657 | ERROR | Missing parameter comment
659 | ERROR | Description for the @return value is missing
663 | ERROR | Type hint "array" missing for $params
679 | ERROR | Missing parameter comment
681 | ERROR | Description for the @return value is missing
685 | ERROR | Type hint "array" missing for $params
701 | ERROR | Missing parameter comment
703 | ERROR | Description for the @return value is missing
707 | ERROR | Type hint "array" missing for $params
723 | ERROR | Missing parameter comment
725 | ERROR | Description for the @return value is missing
729 | ERROR | Type hint "array" missing for $params
745 | ERROR | Missing parameter comment
747 | ERROR | Description for the @return value is missing
769 | ERROR | Missing parameter comment
770 | ERROR | Missing parameter comment
772 | ERROR | Description for the @return value is missing
776 | ERROR | Type hint "array" missing for $params
792 | ERROR | Missing parameter comment
794 | ERROR | Description for the @return value is missing
798 | ERROR | Type hint "array" missing for $params
814 | ERROR | Missing parameter comment
816 | ERROR | Description for the @return value is missing
820 | ERROR | Type hint "array" missing for $params
836 | ERROR | Missing parameter comment
838 | ERROR | Description for the @return value is missing
842 | ERROR | Type hint "array" missing for $params
858 | ERROR | Missing parameter comment
859 | ERROR | Missing parameter comment
861 | ERROR | Description for the @return value is missing
865 | ERROR | Type hint "array" missing for $params
881 | ERROR | Missing parameter comment
883 | ERROR | Description for the @return value is missing
887 | ERROR | Type hint "array" missing for $params
903 | ERROR | Missing parameter comment
905 | ERROR | Description for the @return value is missing
909 | ERROR | Type hint "array" missing for $params
925 | ERROR | Missing parameter comment
927 | ERROR | Description for the @return value is missing
931 | ERROR | Type hint "array" missing for $params
952 | ERROR | Missing parameter comment
954 | ERROR | Description for the @return value is missing
958 | ERROR | Type hint "array" missing for $params
977 | ERROR | Missing parameter comment
979 | ERROR | Description for the @return value is missing
983 | ERROR | Type hint "array" missing for $params
1002 | ERROR | Missing parameter comment
1004 | ERROR | Description for the @return value is missing
1008 | ERROR | Type hint "array" missing for $params
1027 | ERROR | Missing parameter comment
1029 | ERROR | Description for the @return value is missing
1033 | ERROR | Type hint "array" missing for $params
1052 | ERROR | Missing parameter comment
1054 | ERROR | Description for the @return value is missing
1058 | ERROR | Type hint "array" missing for $params
1074 | ERROR | Missing parameter comment
1075 | ERROR | Missing parameter comment
1076 | ERROR | Missing parameter comment
1077 | ERROR | Missing parameter comment
1078 | ERROR | Missing parameter comment
1080 | ERROR | Description for the @return value is missing
1086 | ERROR | Type hint "array" missing for $headers
-------------------------------------------------------------------------

Time: 278ms; Memory: 12Mb