https://git.drupal.org/project/sendpulse.git

Git errors:

Review of the 7.x-1.x branch (commit ad658a9):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: ...areviewsh/pareview_temp/modules/sendpulse_push/sendpulse_push.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    5 | WARNING | There must be no blank line following an inline comment
    --------------------------------------------------------------------------

    FILE: ...dules/sendpulse_addressbook/includes/sendpulse_addressbook.admin.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
    232 | WARNING | Unused variable $category_name.
    278 | WARNING | Unused variable $category_name.
    --------------------------------------------------------------------------

    Time: 98ms; Memory: 8Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: ...review_temp/modules/sendpulse_push/includes/sendpulse_push.forms.inc
--------------------------------------------------------------------------
FOUND 5 ERRORS AND 6 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------
30 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
38 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
49 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: TRUE
51 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
91 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
145 | ERROR | [x] Whitespace found at end of line
150 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
190 | ERROR | [x] Whitespace found at end of line
256 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ''
276 | ERROR | [ ] Type hint "array" missing for $form
276 | ERROR | [ ] Type hint "array" missing for $form_state
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...areviewsh/pareview_temp/modules/sendpulse_push/sendpulse_push.module
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
5 | ERROR | [x] Comments may not appear after statements
210 | ERROR | [ ] Description for the @return value is missing
250 | ERROR | [x] Expected "int|null" but found "int|NULL" for function
| | return type
253 | ERROR | [ ] Type hint "\SendPulse\ApiClient" missing for $client
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...view_temp/modules/sendpulse_addressbook/sendpulse_addressbook.module
--------------------------------------------------------------------------
FOUND 29 ERRORS AND 7 WARNINGS AFFECTING 31 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
103 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
109 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
163 | ERROR | [ ] Missing short description in doc comment
164 | ERROR | [ ] Missing parameter comment
165 | ERROR | [ ] Missing parameter comment
165 | ERROR | [ ] Missing parameter type
166 | ERROR | [ ] Description for the @return value is missing
197 | ERROR | [ ] Doc comment short description must be on a single
| | line, further text should be a separate paragraph
201 | ERROR | [x] Expected "object" but found "stdClass" for parameter
| | type
207 | ERROR | [ ] Type hint "array" missing for $address_books
223 | ERROR | [ ] Missing short description in doc comment
226 | ERROR | [ ] Missing parameter comment
226 | ERROR | [ ] Missing parameter type
227 | ERROR | [ ] Description for the @return value is missing
290 | ERROR | [x] Expected "int" but found "integer" for @var tag in
| | member variable comment
306 | ERROR | [ ] Class property $sendpulse_abid should use lowerCamel
| | naming without underscores
320 | ERROR | [ ] Class property $all_email_qty should use lowerCamel
| | naming without underscores
327 | ERROR | [ ] Class property $active_email_qty should use
| | lowerCamel naming without underscores
334 | ERROR | [ ] Class property $inactive_email_qty should use
| | lowerCamel naming without underscores
356 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
369 | ERROR | [ ] Public method name
| | "SendpulseAddressbookEntityUIController::hook_menu"
| | is not in lowerCamel format
401 | ERROR | [ ] Parameter $conditions is not described in comment
401 | ERROR | [ ] Parameter $id is not described in comment
401 | ERROR | [ ] Parameter $entity is not described in comment
403 | ERROR | [ ] Doc comment short description must be on a single
| | line, further text should be a separate paragraph
405 | ERROR | [ ] Missing parameter type
418 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
427 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: entityType
435 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
451 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
465 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
506 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
524 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
591 | ERROR | [ ] Type hint "array" missing for $abids
591 | ERROR | [ ] Type hint "array" missing for $conditions
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...dules/sendpulse_addressbook/includes/sendpulse_addressbook.admin.inc
--------------------------------------------------------------------------
FOUND 23 ERRORS AND 2 WARNINGS AFFECTING 23 LINES
--------------------------------------------------------------------------
138 | ERROR | [ ] Missing short description in doc comment
141 | ERROR | [ ] Description for the @return value is missing
193 | ERROR | [ ] Missing short description in doc comment
196 | ERROR | [ ] Missing parameter comment
197 | ERROR | [ ] Description for the @return value is missing
216 | ERROR | [ ] Missing short description in doc comment
219 | ERROR | [ ] Missing parameter comment
220 | ERROR | [ ] Description for the @return value is missing
264 | ERROR | [ ] Missing parameter comment
265 | ERROR | [ ] Missing parameter comment
266 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
266 | ERROR | [ ] Description for the @return value is missing
289 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 8
303 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
317 | ERROR | [ ] Missing short description in doc comment
320 | ERROR | [ ] Missing parameter comment
321 | ERROR | [ ] Missing parameter comment
321 | ERROR | [ ] Missing parameter type
339 | ERROR | [ ] Missing short description in doc comment
342 | ERROR | [ ] Missing parameter comment
343 | ERROR | [ ] Description for the @return value is missing
395 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: TRUE
407 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: TRUE
416 | ERROR | [x] Missing function doc comment
431 | ERROR | [x] Expected 1 space after closing parenthesis; found 3
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...dules/sendpulse_addressbook/includes/sendpulse_addressbook.batch.inc
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
25 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
36 | ERROR | [x] Doc comment short description must end with a full
| | stop
40 | WARNING | [ ] Translatable strings must not begin or end with white
| | spaces, use placeholders with t() for variables
40 | ERROR | [ ] Concatenating translatable strings is not allowed,
| | use placeholders instead and only one string literal
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: .../pareview_temp/modules/sendpulse_addressbook/css/sendpulse_admin.css
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
23 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/sendpulse.module
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
69 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
74 | ERROR | [x] Missing function doc comment
76 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 252ms; Memory: 10Mb