https://git.drupal.org/project/sendpulse.git

Git errors:

Review of the 7.x-1.x branch (commit 42ab1bb):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: ...dules/sendpulse_addressbook/includes/sendpulse_addressbook.admin.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
    251 | WARNING | Unused variable $category_name.
    296 | WARNING | Unused variable $category_name.
    --------------------------------------------------------------------------

    Time: 124ms; Memory: 8Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /root/repos/pareviewsh/pareview_temp/sendpulse.module
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
65 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
70 | ERROR | [x] Missing function doc comment
72 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...areviewsh/pareview_temp/modules/sendpulse_push/sendpulse_push.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
204 | ERROR | [ ] Description for the @return value is missing
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...review_temp/modules/sendpulse_push/includes/sendpulse_push.forms.inc
--------------------------------------------------------------------------
FOUND 3 ERRORS AND 6 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------
30 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
38 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
49 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: TRUE
51 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
91 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
152 | ERROR | [x] Whitespace found at end of line
157 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
205 | ERROR | [x] Whitespace found at end of line
266 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ''
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: .../pareview_temp/modules/sendpulse_addressbook/css/sendpulse_admin.css
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
22 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...view_temp/modules/sendpulse_addressbook/sendpulse_addressbook.module
--------------------------------------------------------------------------
FOUND 27 ERRORS AND 6 WARNINGS AFFECTING 28 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
129 | ERROR | [ ] Missing short description in doc comment
130 | ERROR | [ ] Missing parameter comment
131 | ERROR | [ ] Missing parameter comment
131 | ERROR | [ ] Missing parameter type
132 | ERROR | [ ] Description for the @return value is missing
163 | ERROR | [ ] Doc comment short description must be on a single
| | line, further text should be a separate paragraph
167 | ERROR | [x] Expected "object" but found "stdClass" for parameter
| | type
173 | ERROR | [ ] Type hint "array" missing for $address_books
189 | ERROR | [ ] Missing short description in doc comment
192 | ERROR | [ ] Missing parameter comment
192 | ERROR | [ ] Missing parameter type
193 | ERROR | [ ] Description for the @return value is missing
256 | ERROR | [x] Expected "int" but found "integer" for @var tag in
| | member variable comment
272 | ERROR | [ ] Class property $sendpulse_abid should use lowerCamel
| | naming without underscores
286 | ERROR | [ ] Class property $all_email_qty should use lowerCamel
| | naming without underscores
293 | ERROR | [ ] Class property $active_email_qty should use
| | lowerCamel naming without underscores
300 | ERROR | [ ] Class property $inactive_email_qty should use
| | lowerCamel naming without underscores
322 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
335 | ERROR | [ ] Public method name
| | "SendpulseAddressbookEntityUIController::hook_menu"
| | is not in lowerCamel format
367 | ERROR | [ ] Parameter $conditions is not described in comment
367 | ERROR | [ ] Parameter $id is not described in comment
367 | ERROR | [ ] Parameter $entity is not described in comment
369 | ERROR | [ ] Doc comment short description must be on a single
| | line, further text should be a separate paragraph
371 | ERROR | [ ] Missing parameter type
384 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
393 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: entityType
401 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
417 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
431 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
486 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
553 | ERROR | [ ] Type hint "array" missing for $abids
553 | ERROR | [ ] Type hint "array" missing for $conditions
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...dules/sendpulse_addressbook/includes/sendpulse_addressbook.batch.inc
--------------------------------------------------------------------------
FOUND 15 ERRORS AND 2 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------
8 | ERROR | [ ] Missing short description in doc comment
11 | ERROR | [ ] Missing parameter comment
11 | ERROR | [ ] Missing parameter type
12 | ERROR | [ ] Missing parameter comment
12 | ERROR | [ ] Missing parameter type
13 | ERROR | [ ] Missing parameter comment
13 | ERROR | [ ] Missing parameter type
31 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: ]
42 | ERROR | [ ] Missing short description in doc comment
45 | ERROR | [ ] Missing parameter comment
45 | ERROR | [ ] Missing parameter type
46 | ERROR | [ ] Missing parameter comment
46 | ERROR | [ ] Missing parameter type
47 | ERROR | [ ] Missing parameter comment
47 | ERROR | [ ] Missing parameter type
51 | WARNING | [ ] Translatable strings must not begin or end with white
| | spaces, use placeholders with t() for variables
51 | ERROR | [ ] Concatenating translatable strings is not allowed,
| | use placeholders instead and only one string literal
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...dules/sendpulse_addressbook/includes/sendpulse_addressbook.admin.inc
--------------------------------------------------------------------------
FOUND 19 ERRORS AFFECTING 18 LINES
--------------------------------------------------------------------------
157 | ERROR | Missing short description in doc comment
160 | ERROR | Description for the @return value is missing
212 | ERROR | Missing short description in doc comment
215 | ERROR | Missing parameter comment
216 | ERROR | Description for the @return value is missing
235 | ERROR | Missing short description in doc comment
238 | ERROR | Missing parameter comment
239 | ERROR | Description for the @return value is missing
280 | ERROR | Missing short description in doc comment
283 | ERROR | Missing parameter comment
284 | ERROR | Missing parameter comment
285 | ERROR | Description for the @return value is missing
310 | ERROR | Missing short description in doc comment
313 | ERROR | Missing parameter comment
314 | ERROR | Missing parameter comment
314 | ERROR | Missing parameter type
332 | ERROR | Missing short description in doc comment
335 | ERROR | Missing parameter comment
336 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------

Time: 192ms; Memory: 10Mb