http://git.drupal.org/project/drupal_to_slack.git 8.x-1.x

Git errors:

Review of the 8.x-1.x branch (commit a57a322):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: /root/repos/pareviewsh/pareview_temp/drupal_to_slack.admin.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
    --------------------------------------------------------------------------
    10 | WARNING | #description values usually have to run through t() for
    | | translation
    11 | WARNING | All variables defined by your module must be prefixed
    | | with your module's name to avoid name collisions with
    | | others. Expected start with "drupal_to_slack.info" but
    | | found "drupal_to_slack_incoming_webhook_url"
    16 | WARNING | #description values usually have to run through t() for
    | | translation
    17 | WARNING | All variables defined by your module must be prefixed
    | | with your module's name to avoid name collisions with
    | | others. Expected start with "drupal_to_slack.info" but
    | | found "drupal_to_slack_channel_for_message"
    27 | WARNING | All variables defined by your module must be prefixed
    | | with your module's name to avoid name collisions with
    | | others. Expected start with "drupal_to_slack.info" but
    | | found "node_to_notify_on_slack"
    --------------------------------------------------------------------------

    FILE: /root/repos/pareviewsh/pareview_temp/src/Form/SettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
    --------------------------------------------------------------------------
    41 | WARNING | t() calls should be avoided in classes, use dependency
    | | injection and $this->t() instead
    47 | WARNING | t() calls should be avoided in classes, use dependency
    | | injection and $this->t() instead
    49 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    58 | WARNING | t() calls should be avoided in classes, use dependency
    | | injection and $this->t() instead
    69 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    --------------------------------------------------------------------------

    FILE: /root/repos/pareviewsh/pareview_temp/drupal_to_slack.module
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    ----------------------------------------------------------------------
    40 | WARNING | Unused variable $name.
    41 | WARNING | Unused variable $type.
    63 | WARNING | Variable $full_name is undefined.
    ----------------------------------------------------------------------

    Time: 33ms; Memory: 4Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /root/repos/pareviewsh/pareview_temp/drupal_to_slack.links.menu.yml
-------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/drupal_to_slack.admin.inc
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
| | line
4 | ERROR | [x] Doc comment short description must end with a full stop
5 | ERROR | [x] There must be exactly one blank line after the file
| | comment
6 | ERROR | [x] Missing function doc comment
6 | ERROR | [x] Expected 1 blank line before function; 0 found
7 | ERROR | [x] Short array syntax must be used to define arrays
13 | ERROR | [x] Short array syntax must be used to define arrays
23 | ERROR | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/drupal_to_slack.routing.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/Form/SettingsForm.php
--------------------------------------------------------------------------
FOUND 7 ERRORS AND 1 WARNING AFFECTING 8 LINES
--------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not
| | begin with a file doc comment
5 | ERROR | [x] Doc comment short description must end with a full
| | stop
12 | WARNING | [x] Unused use statement
14 | ERROR | [x] Missing class doc comment
37 | ERROR | [x] Short array syntax must be used to define arrays
43 | ERROR | [x] Short array syntax must be used to define arrays
54 | ERROR | [x] Short array syntax must be used to define arrays
73 | ERROR | [x] Object operator not indented correctly; expected 6
| | spaces but found 8
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/drupal_to_slack.info.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
4 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/drupal_to_slack.install
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
5 | ERROR | [x] Doc comment short description must end with a full stop
6 | ERROR | [x] There must be exactly one blank line after the file
| | comment
7 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/drupal_to_slack.module
--------------------------------------------------------------------------
FOUND 20 ERRORS AND 3 WARNINGS AFFECTING 20 LINES
--------------------------------------------------------------------------
5 | ERROR | [x] Doc comment short description must end with a full
| | stop
6 | ERROR | [x] There must be exactly one blank line after the file
| | comment
9 | ERROR | [x] Missing function doc comment
20 | ERROR | [x] Short array syntax must be used to define arrays
33 | ERROR | [x] Function comment short description must start with
| | exactly one space
33 | ERROR | [x] Doc comment short description must end with a full
| | stop
36 | ERROR | [x] Short array syntax must be used to define arrays
37 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
39 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
45 | WARNING | [ ] All constants defined by a module must be prefixed
| | with the module's name, expected
| | "DRUPAL_TO_SLACK_SLACK_WEBHOOK" but found
| | "SLACK_WEBHOOK"
50 | ERROR | [x] Short array syntax must be used to define arrays
51 | ERROR | [x] Array indentation error, expected 6 spaces but found
| | 8
52 | ERROR | [x] Array indentation error, expected 6 spaces but found
| | 8
53 | ERROR | [x] Array indentation error, expected 6 spaces but found
| | 8
53 | ERROR | [x] Short array syntax must be used to define arrays
57 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: true
57 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
60 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
61 | ERROR | [x] Short array syntax must be used to define arrays
65 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $attachments
68 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing parentheses
70 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
71 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 22 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/README.txt
-----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------
43 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
63 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

Time: 102ms; Memory: 6Mb