http://git.drupal.org/project/drupal_to_slack.git 7.x-1.x

Git errors:

Review of the 7.x-1.x branch (commit ee50a68):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: /root/repos/pareviewsh/pareview_temp/drupal_to_slack.admin.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
    10 | WARNING | #description values usually have to run through t() for
    | | translation
    16 | WARNING | #description values usually have to run through t() for
    | | translation
    27 | WARNING | All variables defined by your module must be prefixed
    | | with your module's name to avoid name collisions with
    | | others. Expected start with "drupal_to_slack" but found
    | | "node_to_notify_on_slack"
    --------------------------------------------------------------------------

    FILE: /root/repos/pareviewsh/pareview_temp/drupal_to_slack.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
    63 | WARNING | Are you accessing field values here? Then you should use
    | | LANGUAGE_NONE instead of 'und'
    64 | WARNING | Are you accessing field values here? Then you should use
    | | LANGUAGE_NONE instead of 'und'
    73 | WARNING | Are you accessing field values here? Then you should use
    | | LANGUAGE_NONE instead of 'und'
    75 | WARNING | Unused variable $uri.
    --------------------------------------------------------------------------

    Time: 35ms; Memory: 4Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /root/repos/pareviewsh/pareview_temp/drupal_to_slack.admin.inc
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
| | line
4 | ERROR | [x] Doc comment short description must end with a full stop
5 | ERROR | [x] There must be exactly one blank line after the file
| | comment
6 | ERROR | [x] Missing function doc comment
6 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/drupal_to_slack.module
--------------------------------------------------------------------------
FOUND 32 ERRORS AND 7 WARNINGS AFFECTING 32 LINES
--------------------------------------------------------------------------
6 | ERROR | [x] There must be exactly one blank line after the file
| | comment
7 | ERROR | [x] Missing function doc comment
21 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
27 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'Administration permission for slack to drupal
| | menu link'
28 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
33 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
| | Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
33 | ERROR | [x] Doc comment short description must end with a full
| | stop
34 | ERROR | [x] There must be no blank lines after the function
| | comment
38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
42 | ERROR | [x] Closing brace indented incorrectly; expected 1
| | spaces, found 0
43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3
45 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3
45 | ERROR | [x] Expected 1 space after "="; 2 found
45 | ERROR | [x] Concat operator must be surrounded by a single space
45 | ERROR | [x] Concat operator must be surrounded by a single space
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 3
49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
53 | ERROR | [x] Function comment short description must start with
| | exactly one space
53 | ERROR | [x] Doc comment short description must end with a full
| | stop
54 | ERROR | [x] There must be no blank lines after the function
| | comment
70 | WARNING | [ ] All constants defined by a module must be prefixed
| | with the module's name, expected
| | "DRUPAL_TO_SLACK_SLACK_WEBHOOK" but found
| | "SLACK_WEBHOOK"
71 | ERROR | [x] Expected 1 space after "="; 2 found
79 | ERROR | [x] Array indentation error, expected 6 spaces but found
| | 8
80 | ERROR | [x] Array indentation error, expected 6 spaces but found
| | 8
81 | ERROR | [x] Array indentation error, expected 6 spaces but found
| | 8
85 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: true
85 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
88 | ERROR | [x] Closing parenthesis of array declaration must be on a
| | new line
93 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $attachments
96 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing parentheses
98 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
99 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 36 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/drupal_to_slack.install
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
5 | ERROR | [x] Doc comment short description must end with a full stop
6 | ERROR | [x] There must be exactly one blank line after the file
| | comment
7 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/README.txt
-----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------
43 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
63 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

Time: 58ms; Memory: 6Mb