http://git.drupal.org/sandbox/bewilled/2876439.git

Git errors:

Review of the 8.x-4.x branch (commit d4e579c):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).

    /root/repos/pareviewsh/pareview_temp/public/js/rate_field.js: line 74, col 38, Error - Missing semicolon. (semi)
    /root/repos/pareviewsh/pareview_temp/public/js/rate_field.js: line 105, col 36, Error - Missing semicolon. (semi)
    /root/repos/pareviewsh/pareview_temp/public/js/rate_field.js: line 109, col 12, Error - Newline required at end of file but not found. (eol-last)

    3 problems

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: ...pareview_temp/src/Plugin/Field/FieldFormatter/RateFieldFormatter.php
--------------------------------------------------------------------------
FOUND 16 ERRORS AND 1 WARNING AFFECTING 17 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one
| | blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not
| | begin with a file doc comment
29 | ERROR | [x] Short array syntax must be used to define arrays
38 | ERROR | [x] Short array syntax must be used to define arrays
47 | ERROR | [x] Short array syntax must be used to define arrays
48 | ERROR | [x] Expected 1 space before "=>"; 0 found
51 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $user_id
61 | ERROR | [x] Short array syntax must be used to define arrays
62 | ERROR | [x] Expected 1 space before "=>"; 0 found
84 | ERROR | [x] Expected 1 space after "="; 2 found
85 | ERROR | [x] Expected 1 space after "="; 2 found
86 | ERROR | [x] Short array syntax must be used to define arrays
100 | ERROR | [x] Short array syntax must be used to define arrays
101 | ERROR | [x] Short array syntax must be used to define arrays
105 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
110 | ERROR | [x] Expected 1 blank line after function; 0 found
111 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...os/pareviewsh/pareview_temp/src/Plugin/Field/FieldType/RateField.php
--------------------------------------------------------------------------
FOUND 9 ERRORS AND 1 WARNING AFFECTING 10 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one
| | blank line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not
| | begin with a file doc comment
23 | ERROR | [x] Expected 1 space before opening brace; found 2
29 | ERROR | [x] Short array syntax must be used to define arrays
30 | ERROR | [x] Short array syntax must be used to define arrays
31 | ERROR | [x] Short array syntax must be used to define arrays
35 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
53 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "TRUE" but found "true"
56 | ERROR | [x] Expected 1 blank line after function; 0 found
57 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...iewsh/pareview_temp/src/Plugin/Field/FieldWidget/RateFieldWidget.php
--------------------------------------------------------------------------
FOUND 13 ERRORS AFFECTING 13 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
| | line
2 | ERROR | [x] Namespaced classes, interfaces and traits should not
| | begin with a file doc comment
7 | ERROR | [x] There must be one blank line after the namespace
| | declaration
11 | ERROR | [x] There must be one blank line after the last USE
| | statement; 2 found;
24 | ERROR | [x] There must be exactly one newline after the class
| | comment
32 | ERROR | [x] Short array syntax must be used to define arrays
33 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE"
| | but found "true"
35 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
| | "FALSE" but found "false"
40 | ERROR | [x] Short array syntax must be used to define arrays
41 | ERROR | [x] Short array syntax must be used to define arrays
44 | ERROR | [x] Short array syntax must be used to define arrays
56 | ERROR | [x] Expected 1 blank line after function; 0 found
57 | ERROR | [x] The closing brace for the class must have an empty line
| | before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/Entity/RateFieldVote.php
--------------------------------------------------------------------------
FOUND 12 ERRORS AND 4 WARNINGS AFFECTING 14 LINES
--------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not
| | begin with a file doc comment
11 | WARNING | [x] Unused use statement
18 | ERROR | [x] Doc comment short description must end with a full
| | stop
152 | ERROR | [x] Visibility must be declared on method
| | "baseFieldDefinitions"
168 | ERROR | [x] Short array syntax must be used to define arrays
169 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 64
201 | ERROR | [x] Short array syntax must be used to define arrays
202 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 255
208 | ERROR | [x] Short array syntax must be used to define arrays
209 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 64
214 | ERROR | [x] Expected 1 blank line after function; 2 found
217 | ERROR | [x] Missing function doc comment
217 | ERROR | [x] Visibility must be declared on method
| | "getCurrentUserId"
219 | ERROR | [x] Expected 1 blank line after function; 2 found
222 | ERROR | [x] Missing function doc comment
222 | ERROR | [x] Visibility must be declared on method "getCurrentIp"
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...ot/repos/pareviewsh/pareview_temp/src/Entity/RateFieldVoteResult.php
--------------------------------------------------------------------------
FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not
| | begin with a file doc comment
86 | ERROR | [x] Expected 1 blank line after function; 2 found
101 | ERROR | [x] Expected 1 blank line after function; 2 found
150 | ERROR | [x] Short array syntax must be used to define arrays
151 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 64
183 | ERROR | [x] Short array syntax must be used to define arrays
184 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 64
189 | ERROR | [x] Expected 1 newline at end of file; 0 found
189 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...epos/pareviewsh/pareview_temp/src/Controller/RateFieldController.php
--------------------------------------------------------------------------
FOUND 23 ERRORS AND 6 WARNINGS AFFECTING 27 LINES
--------------------------------------------------------------------------
3 | ERROR | [x] Namespaced classes, interfaces and traits should not
| | begin with a file doc comment
5 | ERROR | [x] Doc comment short description must end with a full
| | stop
10 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
22 | ERROR | [x] Missing function doc comment
25 | ERROR | [x] Expected 1 blank line after function; 2 found
29 | ERROR | [x] Doc comment short description must end with a full
| | stop
33 | ERROR | [x] Short array syntax must be used to define arrays
40 | ERROR | [x] Short array syntax must be used to define arrays
46 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $ip
53 | ERROR | [x] Short array syntax must be used to define arrays
57 | ERROR | [x] Doc comment short description must end with a full
| | stop
82 | ERROR | [x] Short array syntax must be used to define arrays
94 | ERROR | [x] Short array syntax must be used to define arrays
101 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
110 | ERROR | [x] Doc comment short description must end with a full
| | stop
117 | ERROR | [x] Short array syntax must be used to define arrays
121 | ERROR | [x] Doc comment short description must end with a full
| | stop
124 | ERROR | [x] No space found before comment text; expected "//
| | Invalidate cache tags" but found "//Invalidate cache
| | tags"
124 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
125 | ERROR | [x] Namespaced classes/interfaces/traits should be
| | referenced with use statements
125 | ERROR | [x] Short array syntax must be used to define arrays
137 | ERROR | [x] Short array syntax must be used to define arrays
141 | ERROR | [x] Short array syntax must be used to define arrays
146 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 0
150 | ERROR | [x] Short array syntax must be used to define arrays
154 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $user_id
165 | ERROR | [x] Expected 1 blank line after function; 0 found
166 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 29 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/rate_field.info.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/rate_field.libraries.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
13 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/public/css/styles.css
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
73 | ERROR | [x] Blank lines are not allowed in class definitions
82 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/rate_field.install
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
| | line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/rate_field.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one
| | blank line
7 | WARNING | [x] Unused use statement
37 | ERROR | [x] Additional blank lines found at end of doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 149ms; Memory: 8Mb