https://git.drupal.org/project/iptc_media.git

Review of the 8.x-1.x branch (commit b5292f1):

  • Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: .../pareview_temp/config/install/media.type.media_iptc_image_bundle.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
15 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/IptcManager.php
--------------------------------------------------------------------------
FOUND 18 ERRORS AND 1 WARNING AFFECTING 14 LINES
--------------------------------------------------------------------------
71 | ERROR | [x] Functions must not contain multiple empty lines in a
| | row; found 3 empty lines
73 | ERROR | [ ] More than 2 empty lines are not allowed
241 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 7
242 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found
| | 8
243 | WARNING | [ ] Line exceeds 80 characters; contains 116 characters
243 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 10
243 | ERROR | [x] No space found before comment text; expected "// $x1
| | = str_replace("public://",
| | "http://localhost/iptc-on-84/sites/default/files/",
| | $file->getFileUri());" but found "//$x1 =
| | str_replace("public://",
| | "http://localhost/iptc-on-84/sites/default/files/",
| | $file->getFileUri());"
244 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 10
244 | ERROR | [x] No space found before comment text; expected "//
| | $info = [];" but found "//$info = [];"
245 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 10
245 | ERROR | [x] No space found before comment text; expected "//
| | $size = getimagesize($x1, $info);" but found
| | "//$size = getimagesize($x1, $info);"
245 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
246 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 10
247 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 10
248 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found
| | 10
249 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found
| | 11
399 | ERROR | [x] Closing brace indented incorrectly; expected 11
| | spaces, found 8
400 | ERROR | [x] Closing brace indented incorrectly; expected 10
| | spaces, found 6
401 | ERROR | [x] Closing brace indented incorrectly; expected 8
| | spaces, found 4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/iptc.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by
| | drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/iptc.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
14 | ERROR | [x] No space found before comment text; expected "//
| | print_r($form_id);" but found "//print_r($form_id);"
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 102ms; Memory: 10Mb