https://git.drupal.org/project/firebase.git

Review of the 8.x-1.x branch (commit ce1fe67):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).

    FILE: /root/repos/pareviewsh/pareview_temp/README.md
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    ----------------------------------------------------------------------
    37 | WARNING | Line exceeds 80 characters; contains 82 characters
    53 | WARNING | Line exceeds 80 characters; contains 84 characters
    ----------------------------------------------------------------------

    FILE: ...pareviewsh/pareview_temp/src/Service/FirebaseNotificationService.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
    160 | ERROR | Parameter $token is not described in comment
    --------------------------------------------------------------------------

    Time: 104ms; Memory: 6Mb

  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: /root/repos/pareviewsh/pareview_temp/firebase.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    8 | WARNING | All dependencies must be prefixed with the project name,
    | | for example "drupal:"
    --------------------------------------------------------------------------

    FILE: ...pareviewsh/pareview_temp/src/Service/FirebaseNotificationService.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
    37 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    67 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    271 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    --------------------------------------------------------------------------

    Time: 33ms; Memory: 4Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.