https://git.drupal.org/project/lionbridge_translation_provider.git 7.x-1.x

Git errors:

  • The following git branches do not match the release branch pattern, you should remove/rename them. See https://www.drupal.org/node/1015226

    7.x-1.1
    remotes/origin/7.x-1.1
    remotes/origin/HEAD -> origin/7.x-1.1

Review of the 7.x-1.x branch (commit 5fea96c):

  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • ./lionbridge_translation_provider.module: all functions should be prefixed with your module/theme name to avoid name clashes. See https://www.drupal.org/node/318#naming

    function lionbridge_translation_provider_tmgmt_translator_plugin_info() {
    function lionbridge_translation_provider_menu() {
    function lionbridge_translation_provider_permission() {
    function _lionbridge_translation_provider_poll_submit($form, &$form_state) {
    function _lionbridge_translation_provider_authorize_quote($form, &$form_state) {
    function _lionbridge_translation_provider_project_complete_callback($secret = NULL) {
    function lionbridge_translation_provider_tmgmt_source_suggestions(array $items, TMGMTJob $job) {
    function _lionbridge_translation_provider_generate_file_name($file_name, $source_language, $target_language) {
    function _lionbridge_translation_provider_batch(\TMGMTJob $job, $data) {
    function _lionbridge_translation_provider_batch_op(\TMGMTJob $job, $tjiid, $data_items, &$context) {
    function _lionbridge_translation_provider_batch_finished($success, $results, $operations) {
    function _lionbridge_translation_provider_validate_endpoint_url($element, &$form_state) {
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: .../pareviewsh/pareview_temp/lionbridge_translation_provider.plugin.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
    11 | WARNING | Class name must be prefixed with the project name
    | | "I18nNodeRiverLangFilter"
    113 | WARNING | Unused variable $items.
    --------------------------------------------------------------------------

    FILE: ...epos/pareviewsh/pareview_temp/lionbridge_translation_provider.ui.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    11 | WARNING | Class name must be prefixed with the project name
    | | "I18nNodeRiverLangFilter"
    --------------------------------------------------------------------------

    FILE: ...epos/pareviewsh/pareview_temp/lionbridge_translation_provider.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    50 | WARNING | Open page callback found, please add a comment before the
    | | line why there is no access restriction
    --------------------------------------------------------------------------

    FILE: ...reviewsh/pareview_temp/lionbridge_translation_provider.connector.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    11 | WARNING | Class name must be prefixed with the project name
    | | "I18nNodeRiverLangFilter"
    --------------------------------------------------------------------------

    Time: 82ms; Memory: 8Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: ...pos/pareviewsh/pareview_temp/lionbridge_translation_provider.install
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
| | line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...reviewsh/pareview_temp/lionbridge_translation_provider.connector.inc
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
556 | ERROR | Parameter $method is not described in comment
556 | ERROR | Parameter $micro_time is not described in comment
--------------------------------------------------------------------------

FILE: ...ot/repos/pareviewsh/pareview_temp/i18n_node_river_lang_filter.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
33 | ERROR | [x] Object operator not indented correctly; expected 8
| | spaces but found 6
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 164ms; Memory: 10Mb