http://git.drupal.org/project/advban.git

Review of the 8.x-1.x branch (commit eb73f21):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).

    FILE: /root/repos/pareviewsh/pareview_temp/src/AdvbanIpManager.php
    ----------------------------------------------------------------------
    FOUND 2 ERRORS AFFECTING 2 LINES
    ----------------------------------------------------------------------
    96 | ERROR | [x] Whitespace found at end of line
    100 | ERROR | [x] Whitespace found at end of line
    ----------------------------------------------------------------------
    PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------

    Time: 178ms; Memory: 8Mb

  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: /root/repos/pareviewsh/pareview_temp/advban.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    12 | WARNING | Global constants should not be used, move it to a class
    | | or interface
    --------------------------------------------------------------------------

    FILE: /root/repos/pareviewsh/pareview_temp/src/AdvbanIpManager.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    37 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    --------------------------------------------------------------------------

    Time: 69ms; Memory: 6Mb

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.