https://git.drupal.org/project/views_simplechart.git

Git errors:

Review of the 8.x-1.x branch (commit 5ffe6b1):

  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: /root/repos/pareviewsh/pareview_temp/views_simplechart.theme.inc
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------
    10 | WARNING | Unused variable $key.
    ----------------------------------------------------------------------

    FILE: /root/repos/pareviewsh/pareview_temp/views_simplechart.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    11 | WARNING | All dependencies must be prefixed with the project name,
    | | for example "drupal:"
    --------------------------------------------------------------------------

    Time: 22ms; Memory: 4Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /root/repos/pareviewsh/pareview_temp/views_simplechart.theme.inc
--------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
3 | ERROR | [x] Missing function doc comment
9 | ERROR | [x] Expected 1 space after FOR keyword; 0 found
10 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
11 | ERROR | [x] Expected 1 space before "+"; 0 found
11 | ERROR | [x] Expected 1 space after "+"; 0 found
18 | ERROR | [x] Expected 1 space after IF keyword; 0 found
18 | ERROR | [x] Expected one space after the comma, 0 found
18 | ERROR | [x] Short array syntax must be used to define arrays
18 | ERROR | [x] Expected 1 space between comma and "'ColumnChart'"; 0
| | found
18 | ERROR | [x] Expected one space after the comma, 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/views_simplechart.info.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
11 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...pareviewsh/pareview_temp/src/Plugin/views/style/ViewsSimplechart.php
--------------------------------------------------------------------------
FOUND 29 ERRORS AFFECTING 24 LINES
--------------------------------------------------------------------------
38 | ERROR | [x] Doc comment short description must end with a full
| | stop
42 | ERROR | [x] Short array syntax must be used to define arrays
43 | ERROR | [x] Short array syntax must be used to define arrays
44 | ERROR | [x] Short array syntax must be used to define arrays
45 | ERROR | [x] Short array syntax must be used to define arrays
46 | ERROR | [x] Short array syntax must be used to define arrays
47 | ERROR | [x] Short array syntax must be used to define arrays
48 | ERROR | [x] Short array syntax must be used to define arrays
58 | ERROR | [x] Short array syntax must be used to define arrays
64 | ERROR | [x] Short array syntax must be used to define arrays
71 | ERROR | [x] Short array syntax must be used to define arrays
74 | ERROR | [x] Short array syntax must be used to define arrays
84 | ERROR | [x] Short array syntax must be used to define arrays
87 | ERROR | [x] Short array syntax must be used to define arrays
87 | ERROR | [x] Expected one space after the comma, 0 found
91 | ERROR | [x] Short array syntax must be used to define arrays
94 | ERROR | [ ] If the line declaring an array spans longer than 80
| | characters, each element should be broken into its own
| | line
94 | ERROR | [x] Short array syntax must be used to define arrays
94 | ERROR | [x] Expected one space after the comma, 0 found
94 | ERROR | [x] Expected one space after the comma, 0 found
94 | ERROR | [x] Expected one space after the comma, 0 found
97 | ERROR | [x] Short array syntax must be used to define arrays
103 | ERROR | [x] Short array syntax must be used to define arrays
110 | ERROR | [x] Whitespace found at end of line
111 | ERROR | [ ] Missing short description in doc comment
113 | ERROR | [ ] Description for the @return value is missing
115 | ERROR | [ ] Public method name
| | "ViewsSimplechart::get_render_fields" is not in
| | lowerCamel format
117 | ERROR | [x] Expected 1 blank line after function; 0 found
118 | ERROR | [x] The closing brace for the class must have an empty
| | line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 25 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/views_simplechart.module
--------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
6 | ERROR | [x] Expected 1 space before opening brace; found 0
7 | ERROR | [x] Short array syntax must be used to define arrays
8 | ERROR | [x] Short array syntax must be used to define arrays
11 | ERROR | [x] Short array syntax must be used to define arrays
12 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: NULL
16 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 80ms; Memory: 6Mb