http://git.drupal.org/sandbox/dsvoboda/2616794.git

Review of the 7.x-1.x branch (commit 8575451):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: /root/repos/pareviewsh/pareview_temp/prepopulatedfields.install
    -------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------
    127 | WARNING | There must be no blank line following an inline comment
    -------------------------------------------------------------------------

    FILE: /root/repos/pareviewsh/pareview_temp/prepopulatedfields.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
    65 | WARNING | Unused variable $key.
    113 | WARNING | Do not call theme functions directly, use
    | | theme('prepopulatedfields', ...) instead
    209 | WARNING | Unused variable $key.
    --------------------------------------------------------------------------

    Time: 36ms; Memory: 6Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /root/repos/pareviewsh/pareview_temp/prepopulatedfields.install
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
43 | ERROR | [x] Expected 1 blank line after function; 0 found
59 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
122 | ERROR | [x] Expected 1 blank line after function; 0 found
127 | WARNING | [x] There must be no blank line following an inline
| | comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/prepopulatedfields.module
--------------------------------------------------------------------------
FOUND 8 ERRORS AND 2 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------
9 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
9 | ERROR | [x] Whitespace found at end of line
14 | ERROR | [x] Equals sign not aligned with surrounding
| | assignments; expected 1 space but found 2 spaces
91 | ERROR | [x] Whitespace found at end of line
104 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $avail_nodes
106 | ERROR | [x] Whitespace found at end of line
165 | ERROR | [x] Spaces must be used to indent lines; tabs are not
| | allowed
165 | ERROR | [x] Line indented incorrectly; expected 10 spaces, found
| | 7
220 | ERROR | [x] Expected one space after the comma, 0 found
225 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 149ms; Memory: 8Mb