https://git.drupal.org/project/config_provider.git

Git errors:

Review of the 8.x-1.x branch (commit 18b296b):

  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: ...h/pareview_temp/src/Plugin/ConfigProvider/ConfigProviderOptional.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    76 | WARNING | Variable $dependency is undefined.
    --------------------------------------------------------------------------

    FILE: /root/repos/pareviewsh/pareview_temp/src/Plugin/ConfigCollector.php
    -------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -------------------------------------------------------------------------
    80 | WARNING | Unused variable $config_providers.
    -------------------------------------------------------------------------

    FILE: /root/repos/pareviewsh/pareview_temp/config_provider.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
    7 | WARNING | All dependencies must be prefixed with the project name,
    | | for example "drupal:"
    --------------------------------------------------------------------------

    Time: 52ms; Memory: 6Mb

  • Codespell has found some spelling errors in your code.

    ./src/Plugin/ConfigProvider/ConfigProviderInstall.php:31: aready ==> already
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: ...h/pareview_temp/src/Plugin/ConfigProvider/ConfigProviderOptional.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
51 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...oot/repos/pareviewsh/pareview_temp/src/Plugin/ConfigProviderBase.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
163 | ERROR | [x] Case breaking statements must be followed by a
| | single blank line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/Plugin/ConfigCollector.php
-------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------
6 | WARNING | [x] Unused use statement
7 | WARNING | [x] Unused use statement
8 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
-------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------

FILE: ...epos/pareviewsh/pareview_temp/src/Plugin/ConfigProviderInterface.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
18 | ERROR | [ ] Doc comment short description must be on a single line,
| | further text should be a separate paragraph
45 | ERROR | [ ] Parameter $active_storage is not described in comment
48 | ERROR | [ ] Doc comment for parameter $storage does not match
| | actual variable name $active_storage
61 | ERROR | [ ] Parameter $config_to_create is not described in comment
71 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...repos/pareviewsh/pareview_temp/src/ConfigProviderConfigInstaller.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------
7 | WARNING | [x] Unused use statement
10 | ERROR | [x] Missing class doc comment
17 | ERROR | [x] Data types in @param tags need to be fully namespaced
20 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
| | 2 spaces
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 188ms; Memory: 8Mb