https://git.drupal.org/project/tableform.git

Git errors:

Review of the 7.x-1.x branch (commit 40c4ce8):

  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • Remove "version" from the ./tableform_example/tableform_example.info file, it will be added by drupal.org packaging automatically.
  • Remove "version" from the ./tableform.info file, it will be added by drupal.org packaging automatically.
  • ./tableform.module: all functions should be prefixed with your module/theme name to avoid name clashes. See https://www.drupal.org/node/318#naming

    function form_process_tableform($element) {
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: .../pareviewsh/pareview_temp/tableform_example/tableform_example.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
    --------------------------------------------------------------------------
    44 | WARNING | #options values usually have to run through t() for
    | | translation
    51 | WARNING | #options values usually have to run through t() for
    | | translation
    55 | WARNING | #options values usually have to run through t() for
    | | translation
    65 | WARNING | #options values usually have to run through t() for
    | | translation
    78 | WARNING | #options values usually have to run through t() for
    | | translation
    85 | WARNING | #options values usually have to run through t() for
    | | translation
    95 | WARNING | #options values usually have to run through t() for
    | | translation
    --------------------------------------------------------------------------

    FILE: /root/repos/pareviewsh/pareview_temp/tableform.module
    ----------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    ----------------------------------------------------------------------
    60 | WARNING | Unused variable $row_key.
    ----------------------------------------------------------------------

    Time: 80ms; Memory: 4Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: .../pareviewsh/pareview_temp/tableform_example/tableform_example.module
--------------------------------------------------------------------------
FOUND 19 ERRORS AND 1 WARNING AFFECTING 19 LINES
--------------------------------------------------------------------------
3 | ERROR | [x] You must use "/**" style comments for a file comment
5 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found
| | 0
8 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
8 | ERROR | [x] Doc comment short description must end with a full
| | stop
17 | ERROR | [x] Whitespace found at end of line
22 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found
| | 8
23 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found
| | 0
26 | ERROR | [x] Doc comment short description must end with a full
| | stop
32 | ERROR | [x] Whitespace found at end of line
43 | ERROR | [ ] Key specified for array entry; first entry has no
| | key
46 | ERROR | [x] Whitespace found at end of line
60 | ERROR | [x] Whitespace found at end of line
70 | ERROR | [x] Whitespace found at end of line
77 | ERROR | [ ] Key specified for array entry; first entry has no
| | key
90 | ERROR | [x] Whitespace found at end of line
102 | ERROR | [x] Whitespace found at end of line
105 | ERROR | [x] Whitespace found at end of line
106 | ERROR | [x] Whitespace found at end of line
113 | ERROR | [x] Whitespace found at end of line
115 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...os/pareviewsh/pareview_temp/tableform_example/tableform_example.info
--------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------
1 | WARNING | [ ] Remove "version" from the info file, it will be added
| | by drupal.org packaging automatically
3 | ERROR | [ ] Drupal 7 core already requires PHP 5.2
4 | ERROR | [ ] It's only necessary to declare files[] if they declare
| | a class or interface.
7 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/tableform.module
--------------------------------------------------------------------------
FOUND 39 ERRORS AND 2 WARNINGS AFFECTING 33 LINES
--------------------------------------------------------------------------
3 | ERROR | [x] You must use "/**" style comments for a file comment
5 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found
| | 0
8 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
8 | ERROR | [x] Doc comment short description must end with a full
| | stop
14 | ERROR | [x] Whitespace found at end of line
19 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
| | Implements hook_foo_BAR_ID_bar() for xyz_bar().",,
| | "* Implements hook_foo_BAR_ID_bar() for
| | xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
| | Implements hook_foo_BAR_ID_bar() for block
| | templates."
19 | ERROR | [x] Doc comment short description must end with a full
| | stop
30 | ERROR | [x] Whitespace found at end of line
31 | ERROR | [x] Whitespace found at end of line
35 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found
| | 8
36 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found
| | 0
41 | ERROR | [ ] Missing parameter type
44 | ERROR | [x] Separate the @param and @return sections by a blank
| | line.
44 | ERROR | [ ] Return type missing for @return tag in function
| | comment
48 | ERROR | [x] Inline comments must start with a capital letter
48 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
50 | ERROR | [x] Whitespace found at end of line
56 | ERROR | [x] Whitespace found at end of line
57 | ERROR | [x] Inline comments must start with a capital letter
57 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
57 | ERROR | [x] Whitespace found at end of line
59 | ERROR | [x] Whitespace found at end of line
67 | ERROR | [x] Whitespace found at end of line
72 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found
| | 8
73 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found
| | 0
78 | ERROR | [ ] Missing parameter type
89 | ERROR | [x] Whitespace found at end of line
90 | ERROR | [x] Inline comments must start with a capital letter
90 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
92 | ERROR | [x] Whitespace found at end of line
95 | ERROR | [x] Whitespace found at end of line
99 | ERROR | [x] Inline comments must start with a capital letter
99 | ERROR | [x] Inline comments must end in full-stops, exclamation
| | marks, colons, question marks, or closing
| | parentheses
101 | ERROR | [x] Whitespace found at end of line
105 | ERROR | [x] Whitespace found at end of line
107 | ERROR | [x] Whitespace found at end of line
111 | ERROR | [x] Whitespace found at end of line
115 | ERROR | [x] Whitespace found at end of line
116 | ERROR | [ ] If the line declaring an array spans longer than 80
| | characters, each element should be broken into its
| | own line
120 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found
| | 8
121 | ERROR | [x] Line indented incorrectly; expected 1 spaces, found
| | 0
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 35 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/tableform.info
--------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------
1 | WARNING | [ ] Remove "version" from the info file, it will be added
| | by drupal.org packaging automatically
4 | ERROR | [ ] Drupal 7 core already requires PHP 5.2
5 | ERROR | [ ] It's only necessary to declare files[] if they declare
| | a class or interface.
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 118ms; Memory: 6Mb