http://git.drupal.org/project/advagg.git 7.x-2.x

Review of the 7.x-2.x branch (commit db2819a):

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: /root/repos/pareviewsh/pareview_temp/advagg_mod/advagg_mod.module
-----------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
-----------------------------------------------------------------------
198 | ERROR | [x] Expected 1 blank line before function; 0 found
526 | ERROR | [x] Expected 1 blank line before function; 0 found
910 | ERROR | [x] Expected 1 blank line before function; 0 found
2714 | WARNING | [ ] The use of function dprint_r() is discouraged
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/advagg_mod/advagg_mod.admin.inc
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------
564 | ERROR | [x] Expected 1 blank line before function; 0 found
603 | ERROR | [x] Expected 1 blank line before function; 0 found
684 | WARNING | [ ] Only string literals should be passed to t() where
| | possible
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...root/repos/pareviewsh/pareview_temp/advagg_mod/advagg_mod.advagg.inc
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
85 | WARNING | Only string literals should be passed to t() where
| | possible
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/advagg.cache.inc
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
17 | ERROR | [x] Expected 1 blank line before function; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/README.txt
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
264 | WARNING | Line exceeds 80 characters; contains 84 characters
394 | WARNING | Line exceeds 80 characters; contains 306 characters
692 | WARNING | Line exceeds 80 characters; contains 106 characters
726 | WARNING | Line exceeds 80 characters; contains 94 characters
----------------------------------------------------------------------

FILE: ...eviewsh/pareview_temp/advagg_ext_compress/advagg_ext_compress.module
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
12 | ERROR | [x] Expected 1 blank line before function; 0 found
35 | ERROR | [x] Expected 1 blank line before function; 0 found
79 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...pos/pareviewsh/pareview_temp/advagg_bundler/advagg_bundler.admin.inc
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
113 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...s/pareviewsh/pareview_temp/advagg_relocate/advagg_relocate.admin.inc
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
90 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 10
91 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 10
109 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 10
110 | ERROR | [x] Array indentation error, expected 8 spaces but found
| | 10
127 | ERROR | [x] Expected 1 blank line before function; 0 found
173 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...epos/pareviewsh/pareview_temp/advagg_relocate/advagg_relocate.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
27 | ERROR | [x] Expected 1 blank line before function; 0 found
92 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/advagg.module
--------------------------------------------------------------------------
FOUND 6 ERRORS AND 4 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------
318 | ERROR | [x] Expected 1 blank line before function; 0 found
720 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
768 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
770 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
1032 | ERROR | [x] Expected 1 blank line before function; 0 found
1089 | ERROR | [x] Expected 1 blank line before function; 0 found
2881 | ERROR | [x] Expected 1 blank line before function; 0 found
3623 | ERROR | [x] Expected 1 blank line before function; 0 found
4357 | WARNING | [ ] The use of function kprint_r() is discouraged
4704 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 5 spaces
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/advagg.missing.inc
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------
608 | ERROR | [x] Expected 1 blank line before function; 0 found
708 | ERROR | [x] Expected 1 blank line before function; 0 found
1087 | ERROR | [x] Expected 1 blank line before function; 0 found
1352 | ERROR | [x] Expected 1 blank line before function; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...ewsh/pareview_temp/advagg_css_compress/advagg_css_compress.admin.inc
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
113 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/advagg_font/advagg_font.install
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
58 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
61 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...oot/repos/pareviewsh/pareview_temp/advagg_font/advagg_font.admin.inc
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
160 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/advagg_font/advagg_font.module
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
33 | ERROR | [x] Expected 1 blank line before function; 0 found
157 | ERROR | [x] Expected 1 blank line before function; 0 found
201 | ERROR | [x] Expected 1 blank line before function; 0 found
332 | ERROR | [x] Equals sign not aligned correctly; expected 1 space
| | but found 5 spaces
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...root/repos/pareviewsh/pareview_temp/advagg_sri/advagg_sri.advagg.inc
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 4 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------
14 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
16 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
18 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
21 | ERROR | [x] Expected 1 blank line before function; 0 found
40 | WARNING | [ ] Hook implementations should not duplicate @param
| | documentation
138 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/advagg_sri/advagg_sri.module
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
23 | ERROR | [x] Expected 1 blank line before function; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/advagg_sri/advagg_sri.admin.inc
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
50 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: ...pareviewsh/pareview_temp/advagg_validator/advagg_validator.admin.inc
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
273 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/advagg.admin.inc
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
1100 | ERROR | [x] Expected 1 blank line before function; 0 found
1183 | ERROR | [x] Expected 1 blank line before function; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: ...viewsh/pareview_temp/advagg_js_compress/advagg_js_compress.admin.inc
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
138 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/advagg.advagg.inc
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------
15 | WARNING | Hook implementations should not duplicate @param
| | documentation
17 | WARNING | Hook implementations should not duplicate @param
| | documentation
19 | WARNING | Hook implementations should not duplicate @param
| | documentation
93 | WARNING | Hook implementations should not duplicate @param
| | documentation
95 | WARNING | Hook implementations should not duplicate @param
| | documentation
97 | WARNING | Hook implementations should not duplicate @param
| | documentation
351 | WARNING | Hook implementations should not duplicate @param
| | documentation
353 | WARNING | Hook implementations should not duplicate @param
| | documentation
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/advagg.inc
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
26 | ERROR | [x] Expected 1 blank line before function; 0 found
425 | ERROR | [x] Expected 1 blank line before function; 0 found
797 | ERROR | [x] Expected 1 blank line before function; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 2.63 secs; Memory: 44.01Mb