https://git.drupal.org/project/rename_admin_paths.git

Git errors:

Review of the 8.x-1.x branch (commit 2894ca3):

  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.

    FILE: ...oot/repos/pareviewsh/pareview_temp/src/RenameAdminPathsProcessor.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
    19 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    56 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    --------------------------------------------------------------------------

    FILE: ...s/pareviewsh/pareview_temp/src/Form/RenameAdminPathsSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
    84 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    92 | WARNING | \Drupal calls should be avoided in classes, use
    | | dependency injection instead
    --------------------------------------------------------------------------

    Time: 26ms; Memory: 4Mb

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

FILE: ...oot/repos/pareviewsh/pareview_temp/src/RenameAdminPathsProcessor.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
16 | WARNING | Line exceeds 80 characters; contains 90 characters
--------------------------------------------------------------------------

FILE: ...epos/pareviewsh/pareview_temp/src/Form/RenameAdminPathsCallbacks.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
21 | WARNING | Line exceeds 80 characters; contains 96 characters
--------------------------------------------------------------------------

FILE: ...s/pareviewsh/pareview_temp/src/Form/RenameAdminPathsSettingsForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
45 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: )
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/rename_admin_paths.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
--------------------------------------------------------------------------

FILE: ...ot/repos/pareviewsh/pareview_temp/rename_admin_paths.permissions.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
4 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 103ms; Memory: 6Mb