http://git.drupal.org/project/admin_content_notification.git

Primary tabs

Review of the 8.x-3.x branch (commit 6de8184):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...pal/pareviewsh/pareview_temp/src/AdminContentNotificationService.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      73 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     124 | WARNING | User::loadMultiple calls should be avoided in classes,
         |         | use dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 222ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...pal/pareviewsh/pareview_temp/src/AdminContentNotificationService.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
  95 | ERROR   | Missing parameter comment
  96 | ERROR   | Missing parameter comment
 116 | WARNING | Only string literals should be passed to t() where
     |         | possible
 117 | WARNING | Only string literals should be passed to t() where
     |         | possible
--------------------------------------------------------------------------


FILE: ...rupal/pareviewsh/pareview_temp/src/Form/AdminContentNotification.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------
 16 | ERROR | [x] The open comment tag must be the only content on the
    |       |     line
 16 | ERROR | [x] Doc comment short description must be on the first line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 437ms; Memory: 4Mb