http://git.drupal.org/project/b2share.git

Primary tabs

Git errors:
  • The following git branches do not match the release branch pattern, you should remove/rename them. See https://www.drupal.org/node/1015226
      7.x-1.0
      remotes/origin/7.x-1.0
      remotes/origin/HEAD -> origin/7.x-1.0
    
Review of the 7.x-1.x branch (commit f12b454):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The b2share.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting
    ./b2share.module:  PHP script, ASCII text, with CRLF line terminators
    b2share.module
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...0/site1101/web/vendor/drupal/pareviewsh/pareview_temp/b2share.module
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     1 | ERROR | [x] End of line character is invalid; expected "\n" but
       |       |     found "\r\n"
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    Time: 719ms; Memory: 10Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...0/site1101/web/vendor/drupal/pareviewsh/pareview_temp/b2share.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 27 WARNINGS AFFECTING 26 LINES
    --------------------------------------------------------------------------
      72 | WARNING | All variables defined by your module must be prefixed
         |         | with your module's name to avoid name collisions with
         |         | others. Expected start with "b2share" but found
         |         | "http_code_visible"
      80 | WARNING | All variables defined by your module must be prefixed
         |         | with your module's name to avoid name collisions with
         |         | others. Expected start with "b2share" but found
         |         | "status_message_visible"
      88 | WARNING | All variables defined by your module must be prefixed
         |         | with your module's name to avoid name collisions with
         |         | others. Expected start with "b2share" but found
         |         | "ignore_outdate_certificates"
      96 | WARNING | All variables defined by your module must be prefixed
         |         | with your module's name to avoid name collisions with
         |         | others. Expected start with "b2share" but found
         |         | "save_dois"
     166 | WARNING | Unused variable $settings.
     315 | WARNING | Variable $foo is undefined.
     315 | WARNING | Variable $foo is undefined.
     396 | WARNING | Potential security problem: SSL peer verification must
         |         | not be disabled
     424 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     431 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     437 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     461 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     475 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     476 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     477 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     478 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     551 | WARNING | Unused variable $header_sent.
     639 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     643 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     647 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     648 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     693 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     694 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     697 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     698 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     701 | WARNING | Are you accessing field values here? Then you should use
         |         | LANGUAGE_NONE instead of 'und'
     723 | WARNING | Unused variable $insert.
    --------------------------------------------------------------------------
    
    Time: 384ms; Memory: 8Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.