http://git.drupal.org/project/cision_block.git 8.x-1.x

Primary tabs

Review of the 8.x-1.x branch (commit 0ff805d):
  • Remove all old CVS $Id tags, they are not needed anymore.
    src/Item/CisionItem.php:9:  public $Id;
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Plugin/Block/CisionBlock.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     105 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 179ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.