Revision of http://git.drupal.org/project/cision_block.git 8.x-1.x from Sat, 02/17/2018 - 21:49

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 4fba786):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The cision_block.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Remove all old CVS $Id tags, they are not needed anymore.
    src/Item/CisionItem.php:9:  public $Id;
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/Item/CisionItem.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     43 | ERROR | Missing @var tag in member variable comment
    --------------------------------------------------------------------------
    
    
    FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Plugin/Block/CisionBlock.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     96 | ERROR | Parameter tags must be grouped together in a doc comment
    --------------------------------------------------------------------------
    
    Time: 396ms; Memory: 4Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Plugin/Block/CisionBlock.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     106 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 164ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.