Revision of http://git.drupal.org/project/cision_block.git 8.x-1.x from Sat, 02/17/2018 - 22:17

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit bb53bfd):
  • Remove all old CVS $Id tags, they are not needed anymore.
    src/Item/CisionItem.php:9:  public $Id;
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Plugin/Block/CisionBlock.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     105 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 176ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/cision_block.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 8 | ERROR | [x] When importing a class with "use", do not include a
   |       |     leading \
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/Item/CisionItem.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 41 | ERROR | [ ] Missing short description in doc comment
 42 | ERROR | [x] Expected
    |       |     "stringAsummarycreatedfromeitherIntroorBodywillbestoredinthisfield"
    |       |     but found "string A summary created from either Intro
    |       |     or Body will be stored in this field." for @var tag in
    |       |     member variable comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 422ms; Memory: 6Mb