Revision of http://git.drupal.org/project/cision_feed.git 7.x-1.x from Mon, 02/19/2018 - 03:11

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 7.x-1.x branch (commit 19c934d):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Remove the translations folder, translations are done on http://localize.drupal.org
  • The cision_feed.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Remove all old CVS $Id tags, they are not needed anymore.
    translations/sv.po:1:# $Id$
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/plugins/CisionFetcher.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      16 | WARNING | Class name must be prefixed with the project name
         |         | "CisionFeed"
     199 | WARNING | Class name must be prefixed with the project name
         |         | "CisionFeed"
    --------------------------------------------------------------------------
    
    
    FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/plugins/CisionParser.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     11 | WARNING | Class name must be prefixed with the project name
        |         | "CisionFeed"
     33 | WARNING | Unused variable $imagesDescriptions.
    --------------------------------------------------------------------------
    
    
    FILE: ...endor/drupal/pareviewsh/pareview_temp/tests/cision_feed_fetcher.test
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     63 | WARNING | There must be no blank line following an inline comment
    --------------------------------------------------------------------------
    
    
    FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/cision_feed.install
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     28 | ERROR | Do not use t() or st() in installation phase hooks, use $t
        |       | = get_t() to retrieve the appropriate localization function
        |       | name
    --------------------------------------------------------------------------
    
    Time: 362ms; Memory: 6Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/plugins/CisionFetcher.inc
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
  93 | ERROR | Type hint "array" missing for $form_state
 142 | ERROR | Type hint "array" missing for $values
 183 | ERROR | Type hint "array" missing for $source_config
 337 | ERROR | The second argument to watchdog() should not be enclosed
     |       | with t()
--------------------------------------------------------------------------


FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/cision_feed.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 29 | ERROR | [x] Array indentation error, expected 8 spaces but found 10
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/tests/cision_feed_fetcher.test
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 63 | WARNING | [x] There must be no blank line following an inline
    |         |     comment
 63 | ERROR   | [x] No space found before comment text; expected "//
    |         |     $this->assertText(t('Created 10 nodes.'));" but found
    |         |     "//$this->assertText(t('Created 10 nodes.'));"
 63 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 676ms; Memory: 6Mb