Revision of http://git.drupal.org/project/cision_feed.git 7.x-1.x from Mon, 02/19/2018 - 03:23

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 7.x-1.x branch (commit a451b56):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The cision_feed.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/plugins/CisionFetcher.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
      16 | WARNING | Class name must be prefixed with the project name
         |         | "CisionFeed"
     199 | WARNING | Class name must be prefixed with the project name
         |         | "CisionFeed"
    --------------------------------------------------------------------------
    
    
    FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/plugins/CisionParser.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     11 | WARNING | Class name must be prefixed with the project name
        |         | "CisionFeed"
    --------------------------------------------------------------------------
    
    Time: 375ms; Memory: 6Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/plugins/CisionFetcher.inc
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
  93 | ERROR | Type hint "array" missing for $form_state
 142 | ERROR | Type hint "array" missing for $values
 183 | ERROR | Type hint "array" missing for $source_config
 337 | ERROR | The second argument to watchdog() should not be enclosed
     |       | with t()
--------------------------------------------------------------------------


FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/cision_feed.module
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 29 | ERROR | [x] Array indentation error, expected 8 spaces but found 10
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 699ms; Memory: 6Mb