http://git.drupal.org/project/commerce_fondy.git

Primary tabs

Review of the 8.x-1.x branch (commit 8f4d7d7):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 1 ERROR AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
  3 | WARNING | [ ] Line exceeds 80 characters; contains 222 characters
  4 | WARNING | [ ] Line exceeds 80 characters; contains 302 characters
 20 | WARNING | [ ] Line exceeds 80 characters; contains 110 characters
 32 | WARNING | [ ] Line exceeds 80 characters; contains 105 characters
 33 | WARNING | [ ] Line exceeds 80 characters; contains 105 characters
 33 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pal/pareviewsh/pareview_temp/config/schema/commerce_fondy.schema.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 15 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...sh/pareview_temp/src/PluginForm/OffsiteRedirect/FondyOffsiteForm.php
--------------------------------------------------------------------------
FOUND 89 ERRORS AND 5 WARNINGS AFFECTING 79 LINES
--------------------------------------------------------------------------
   5 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
   6 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
   7 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
   8 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
   9 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
  11 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
  11 | ERROR   | [x] Missing class doc comment
  12 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  12 | ERROR   | [ ] Missing short description in doc comment
  13 | ERROR   | [x] Expected "stringpayurl" but found "string pay url"
     |         |     for @var tag in member variable comment
  15 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  16 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  17 | ERROR   | [x] Doc comment short description must start with a
     |         |     capital letter
  17 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  19 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  20 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  22 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  22 | ERROR   | [ ] Missing short description in doc comment
  23 | ERROR   | [ ] Missing parameter comment
  23 | ERROR   | [x] Expected 1 spaces after parameter type; 14 found
  24 | ERROR   | [ ] Missing parameter comment
  24 | ERROR   | [x] Data types in @param tags need to be fully
     |         |     namespaced
  26 | ERROR   | [ ] Description for the @return value is missing
  28 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  31 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  33 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  34 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  36 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  38 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  39 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  40 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  41 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  42 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  43 | ERROR   | [x] Object operator not indented correctly; expected 8
     |         |     spaces but found 10
  44 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  45 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  46 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  46 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
  47 | ERROR   | [x] Object operator not indented correctly; expected 10
     |         |     spaces but found 12
  48 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
  49 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  50 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  51 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  52 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  53 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  54 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  55 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  56 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  58 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: 'payment'
  61 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  62 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  63 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  64 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  65 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  68 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  69 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  70 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  71 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  84 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: )
  91 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: )
  94 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  97 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  99 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 101 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 102 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
 103 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
 103 | ERROR   | [ ] Missing parameter comment
 103 | ERROR   | [ ] Missing parameter type
 103 | ERROR   | [x] Tag value indented incorrectly; expected 1 space but
     |         |     found 6
 104 | ERROR   | [ ] Missing parameter comment
 104 | ERROR   | [ ] Missing parameter type
 104 | ERROR   | [x] Tag value indented incorrectly; expected 1 space but
     |         |     found 6
 105 | ERROR   | [ ] Missing parameter comment
 106 | ERROR   | [x] Separate the @param and @return sections by a blank
     |         |     line.
 106 | ERROR   | [ ] Description for the @return value is missing
 109 | ERROR   | [x] Additional blank lines found at end of doc comment
 110 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 111 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 113 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 114 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 115 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 116 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 117 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 118 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 119 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 120 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 121 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 122 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 123 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 124 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 125 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 125 | ERROR   | [x] Expected 1 blank line after function; 0 found
 126 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
 126 | ERROR   | [x] The closing brace for the class must have an empty
     |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 81 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pareview_temp/src/Plugin/Commerce/PaymentGateway/OffsiteRedirect.php
--------------------------------------------------------------------------
FOUND 137 ERRORS AND 4 WARNINGS AFFECTING 129 LINES
--------------------------------------------------------------------------
   5 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
   6 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
   7 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
   8 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
   9 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
  10 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
  11 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
  13 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
  25 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
  27 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  30 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  31 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
  37 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  39 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  42 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  44 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  46 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  54 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  62 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  63 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  70 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  77 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
  78 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  80 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  83 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  84 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
  85 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
  86 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
  87 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
  88 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
  89 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
  90 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
  91 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
  92 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  94 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 100 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 101 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 108 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 110 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 113 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 115 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 117 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: ]
 119 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 120 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 121 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 122 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 124 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 125 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 126 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 127 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 128 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 136 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 137 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 139 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: ]
 141 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 142 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 144 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 147 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 148 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 150 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: ]
 152 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 154 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 155 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 156 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 157 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 158 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 159 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 160 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 161 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 164 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     10
 165 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     10
 166 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 167 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 170 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: ]
 172 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 173 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     10
 174 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 175 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 183 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 184 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 185 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 186 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 188 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 188 | ERROR   | [ ] Missing short description in doc comment
 188 | ERROR   | [ ] Parameter $order is not described in comment
 189 | ERROR   | [ ] Missing parameter comment
 189 | ERROR   | [ ] Missing parameter type
 190 | ERROR   | [ ] Missing parameter comment
 190 | ERROR   | [ ] Missing parameter type
 192 | ERROR   | [ ] Description for the @return value is missing
 194 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 195 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 196 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 197 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 198 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 199 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 200 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 201 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 202 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 203 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 204 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 206 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 209 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 210 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 211 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 212 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 213 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 214 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 215 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 216 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 217 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 218 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 219 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     8
 220 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 222 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     6
 223 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 225 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 225 | ERROR   | [ ] Missing short description in doc comment
 226 | ERROR   | [ ] Missing parameter comment
 226 | ERROR   | [ ] Missing parameter type
 227 | ERROR   | [ ] Missing parameter comment
 227 | ERROR   | [ ] Missing parameter type
 228 | ERROR   | [ ] Missing parameter comment
 228 | ERROR   | [ ] Missing parameter type
 229 | ERROR   | [ ] Missing parameter comment
 229 | ERROR   | [ ] Missing parameter type
 231 | ERROR   | [ ] Description for the @return value is missing
 233 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 233 | ERROR   | [x] Multi-line function declarations must define one
     |         |     parameter per line
 234 | ERROR   | [x] Multi-line function declarations must define one
     |         |     parameter per line
 235 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
 236 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 237 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
 238 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
 239 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 240 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
 242 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     6
 243 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
 243 | ERROR   | [x] Expected 1 blank line after function; 0 found
 244 | ERROR   | [x] Line indented incorrectly; expected 0 spaces, found
     |         |     2
 244 | ERROR   | [x] The closing brace for the class must have an empty
     |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 124 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 860ms; Memory: 6Mb