Revision of http://git.drupal.org/project/country_state_city from Thu, 03/26/2020 - 16:10

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 1d1ae12):
  • Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting
    ./data/cities.json:                                                     ASCII text, with very long lines, with no line terminators
    
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...areview_temp/src/Plugin/Field/FieldWidget/CountryStateCityWidget.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     299 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    Time: 3.62 secs; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.