http://git.drupal.org/project/database_info.git

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit e9d0896):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The CONFIGURATION section is missing.
  • Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     16 | WARNING | Line exceeds 80 characters; contains 91 characters
    --------------------------------------------------------------------------
    
    Time: 313ms; Memory: 4Mb
    
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/database_info.js: line 10, col 7, Error - 'filterTbales' is assigned a value but never used. (no-unused-vars)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/database_info.js: line 13, col 5, Error - Expected indentation of 6 spaces but found 4. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/database_info.js: line 15, col 9, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/database_info.js: line 15, col 29, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/database_info.js: line 17, col 11, Error - Strings must use singlequote. (quotes)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/database_info.js: line 17, col 44, Warning - Too many nested callbacks (4). Maximum allowed is 3. (max-nested-callbacks)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/database_info.js: line 18, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/database_info.js: line 18, col 77, Error - Missing semicolon. (semi)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/database_info.js: line 19, col 11, Error - Expected indentation of 8 spaces but found 10. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/database_info.js: line 20, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/database_info.js: line 21, col 7, Error - Expected indentation of 4 spaces but found 6. (indent)
    
    11 problems
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...l/pareviewsh/pareview_temp/src/Controller/DatabaseInfoController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
    --------------------------------------------------------------------------
      48 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      80 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      81 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      87 | WARNING | Unused variable $key.
     117 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     122 | WARNING | Unused variable $key.
     145 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    Time: 113ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.