http://git.drupal.org/project/fusepump master

Primary tabs

Review of the master branch (commit 8100801):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The fusepump.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/main.js: line 7, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/main.js: line 12, col 5, Error - Expected indentation of 2 spaces but found 4. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/main.js: line 13, col 9, Error - Expected indentation of 6 spaces but found 8. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/main.js: line 14, col 13, Error - Expected indentation of 10 spaces but found 12. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/main.js: line 14, col 47, Error - Missing space before function parentheses. (space-before-function-paren)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/main.js: line 15, col 16, Error - Expected indentation of 14 spaces but found 15. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/main.js: line 16, col 16, Error - Expected indentation of 14 spaces but found 15. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/main.js: line 16, col 49, Error - Trailing spaces not allowed. (no-trailing-spaces)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/main.js: line 17, col 16, Error - Expected indentation of 14 spaces but found 15. (indent)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/js/main.js: line 18, col 16, Error - Expected indentation of 14 spaces but found 15. (indent)
    
    10 problems
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...ite1101/web/vendor/drupal/pareviewsh/pareview_temp/css/jsweights.css
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------
  2 | WARNING | Line exceeds 80 characters; contains 156 characters
 10 | WARNING | Line exceeds 80 characters; contains 108 characters
 13 | WARNING | Line exceeds 80 characters; contains 123 characters
 16 | WARNING | Line exceeds 80 characters; contains 82 characters
 20 | WARNING | Line exceeds 80 characters; contains 143 characters
 26 | WARNING | Line exceeds 80 characters; contains 101 characters
 30 | WARNING | Line exceeds 80 characters; contains 143 characters
 38 | WARNING | Line exceeds 80 characters; contains 107 characters
 42 | WARNING | Line exceeds 80 characters; contains 122 characters
--------------------------------------------------------------------------

Time: 570ms; Memory: 4Mb