http://git.drupal.org/project/readme.git 8.x-1.x

Primary tabs

Review of the 8.x-1.x branch (commit 8802f8c):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The readme.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: .../drupal/pareviewsh/pareview_temp/src/Controller/ReadmeController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     130 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/src/ReadmeManager.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     1 | ERROR | An error occurred during processing; checking has been
       |       | aborted. The error message was: "Token type "T_IF" is not
       |       | T_FUNCTION, T_CLASS, T_INTERFACE or T_TRAIT" at
       |       | /var/vhosts/c214000000/site1101/web/vendor/squizlabs/php_codesniffer/CodeSniffer/File.php:2683
    --------------------------------------------------------------------------
    
    
    FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Form/ReadmeSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     31 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     51 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 575ms; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 47 | WARNING | Line exceeds 80 characters; contains 92 characters
--------------------------------------------------------------------------


FILE: .../drupal/pareviewsh/pareview_temp/src/Controller/ReadmeController.php
--------------------------------------------------------------------------
FOUND 92 ERRORS AFFECTING 85 LINES
--------------------------------------------------------------------------
  16 | ERROR | [x] Whitespace found at end of line
  17 | ERROR | [x] Opening brace should be on the same line as the
     |       |     declaration
  19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  32 | ERROR | [x] Whitespace found at end of line
  33 | ERROR | [x] Opening brace should be on the same line as the
     |       |     declaration
  34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  40 | ERROR | [x] Whitespace found at end of line
  41 | ERROR | [x] Opening brace should be on the same line as the
     |       |     declaration
  42 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  53 | ERROR | [x] Whitespace found at end of line
  54 | ERROR | [x] Opening brace should be on the same line as the
     |       |     declaration
  55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  57 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  61 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
  62 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 16
  63 | ERROR | [x] Array indentation error, expected 18 spaces but found
     |       |     16
  64 | ERROR | [x] Array indentation error, expected 18 spaces but found
     |       |     16
  65 | ERROR | [x] Array indentation error, expected 18 spaces but found
     |       |     16
  67 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
  68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  71 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
  72 | ERROR | [x] Array indentation error, expected 14 spaces but found
     |       |     12
  73 | ERROR | [x] Array indentation error, expected 14 spaces but found
     |       |     12
  75 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  75 | ERROR | [x] Expected newline after closing brace
  76 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
  77 | ERROR | [x] Array indentation error, expected 14 spaces but found
     |       |     12
  79 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  84 | ERROR | [x] Whitespace found at end of line
  85 | ERROR | [x] Doc comment short description must be on the first
     |       |     line
  90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  91 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  92 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  93 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
  96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
  98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 110 | ERROR | [x] Whitespace found at end of line
 111 | ERROR | [x] Opening brace should be on the same line as the
     |       |     declaration
 112 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 113 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 114 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 117 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 119 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 121 | ERROR | [x] Array indentation error, expected 10 spaces but found
     |       |     8
 122 | ERROR | [x] Array indentation error, expected 10 spaces but found
     |       |     8
 123 | ERROR | [x] Array indentation error, expected 10 spaces but found
     |       |     8
 125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 126 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 127 | ERROR | [x] Array indentation error, expected 10 spaces but found
     |       |     8
 128 | ERROR | [x] Array indentation error, expected 10 spaces but found
     |       |     8
 130 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 131 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 131 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
     |       |     "TRUE" but found "true"
 132 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 133 | ERROR | [x] Array indentation error, expected 14 spaces but found
     |       |     12
 134 | ERROR | [x] Array indentation error, expected 14 spaces but found
     |       |     12
 135 | ERROR | [x] Array indentation error, expected 14 spaces but found
     |       |     12
 137 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 138 | ERROR | [x] Array indentation error, expected 14 spaces but found
     |       |     12
 139 | ERROR | [x] Array indentation error, expected 14 spaces but found
     |       |     12
 140 | ERROR | [x] Array indentation error, expected 14 spaces but found
     |       |     12
 142 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 143 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 144 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 146 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 158 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 158 | ERROR | [x] Whitespace found at end of line
 159 | ERROR | [x] Opening brace should be on the same line as the
     |       |     declaration
 160 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 161 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 162 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 164 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 165 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 92 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1101/web/vendor/drupal/pareviewsh/pareview_temp/src/ReadmeAccess.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 22 | ERROR | [x] The static declaration must come after the visibility
    |       |     declaration
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/src/ReadmeManager.php
--------------------------------------------------------------------------
FOUND 46 ERRORS AFFECTING 37 LINES
--------------------------------------------------------------------------
  9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 16 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 21 | ERROR | [x] Whitespace found at end of line
 22 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 29 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL"
    |       |     but found "null"
 30 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 30 | ERROR | [x] Opening brace indented incorrectly; expected 2 spaces,
    |       |     found 4
 31 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 31 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE"
    |       |     but found "true"
 31 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
    |       |     "FALSE" but found "false"
 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 32 | ERROR | [x] Closing brace indented incorrectly; expected 2 spaces,
    |       |     found 4
 37 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL"
    |       |     but found "null"
 37 | ERROR | [x] Whitespace found at end of line
 38 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 39 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 40 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
 41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
 41 | ERROR | [x] Closing brace indented incorrectly; expected 8 spaces,
    |       |     found 10
 42 | ERROR | [x] Whitespace found at end of line
 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 70 | ERROR | [x] Whitespace found at end of line
 71 | ERROR | [x] Doc comment short description must be on the first line
 79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 81 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 10
 81 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected
    |       |     "FALSE" but found "false"
 82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 82 | ERROR | [x] Closing brace indented incorrectly; expected 8 spaces,
    |       |     found 6
 83 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 84 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
 85 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 87 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 8
 88 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 89 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 91 | ERROR | [x] Whitespace found at end of line
 92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 93 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
 94 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 46 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ndor/drupal/pareviewsh/pareview_temp/src/Form/ReadmeSettingsForm.php
--------------------------------------------------------------------------
FOUND 22 ERRORS AFFECTING 20 LINES
--------------------------------------------------------------------------
 12 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 17 | ERROR | [x] Whitespace found at end of line
 18 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 25 | ERROR | [x] Whitespace found at end of line
 26 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 28 | ERROR | [x] Array indentation error, expected 10 spaces but found 9
 29 | ERROR | [x] Array indentation error, expected 10 spaces but found 9
 30 | ERROR | [x] Array indentation error, expected 10 spaces but found 9
 31 | ERROR | [x] Array indentation error, expected 10 spaces but found 9
 34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 9
 35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 9
 36 | ERROR | [x] Array indentation error, expected 11 spaces but found 8
 37 | ERROR | [x] Array indentation error, expected 11 spaces but found 8
 38 | ERROR | [x] Array indentation error, expected 11 spaces but found 8
 45 | ERROR | [x] Closing brace indented incorrectly; expected 4 spaces,
    |       |     found 2
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 22 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...4000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/NOTES.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
 32 | WARNING | Line exceeds 80 characters; contains 117 characters
 35 | WARNING | Line exceeds 80 characters; contains 125 characters
--------------------------------------------------------------------------

Time: 1.27 secs; Memory: 4Mb