http://git.drupal.org/project/splash_screen

Primary tabs

Review of the 8.x-1.x branch (commit 166d2e9):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
  • ./splash_screen.module: All functions should be prefixed with your module/theme name (splash_screen) to avoid name clashes. See https://www.drupal.org/node/318#naming
    function starts_with($haystack, $needle) {
    
  • Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting
    ./splash_screen.links.task.yml:                     ASCII text, with CRLF line terminators
    splash_screen.links.task.yml
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/Form/PopUpForm.php
    --------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------
     135 | ERROR | [x] Inline comments must end in full-stops, exclamation
         |       |     marks, colons, question marks, or closing parentheses
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    Time: 1.89 secs; Memory: 6Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...iewsh/pareview_temp/src/EventSubscriber/CustomredirectSubscriber.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     29 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...l/pareviewsh/pareview_temp/src/Controller/SplashScreenController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     98 | WARNING | t() calls should be avoided in classes, use dependency
        |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    
    FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Form/SplashScreenForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     294 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     320 | WARNING | User::load calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    Time: 973ms; Memory: 6Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.