Revision of http://git.drupal.org/project/tint_connector.git 8.x-1.x from Thu, 08/08/2019 - 18:51

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Git errors: Review of the 8.x-1.x branch (commit 1d8dc3d):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Remove LICENSE.txt, it will be added by drupal.org packaging automatically.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/tint_connector.routing.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     7 | WARNING | The administration page callback should probably use
       |         | "administer site configuration" - which implies the user
       |         | can change something - rather than "access administration
       |         | pages" which is about viewing but not changing
       |         | configurations.
    --------------------------------------------------------------------------
    
    
    FILE: ...ewsh/pareview_temp/src/Plugin/Field/FieldFormatter/TintFormatter.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     33 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Form/TintSettingsForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
      68 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      68 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      95 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      95 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     104 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     104 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    Time: 429ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
 26 | WARNING | [ ] Line exceeds 80 characters; contains 97 characters
 39 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters
 44 | ERROR   | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/tint_connector.module
--------------------------------------------------------------------------
FOUND 4 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
 20 | ERROR   | [x] Whitespace found at end of line
 21 | ERROR   | [x] Case breaking statements must be followed by a single
    |         |     blank line
 22 | WARNING | [ ] Code after RETURN statement cannot be executed
 22 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 23 | ERROR   | [x] Whitespace found at end of line
 29 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
    |         |     Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "*
    |         |     Implements hook_foo_BAR_ID_bar() for
    |         |     xyz-bar.html.twig.", "* Implements
    |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "*
    |         |     Implements hook_foo_BAR_ID_bar() for block
    |         |     templates."
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../pareviewsh/pareview_temp/config/install/tint_connector.settings.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...areviewsh/pareview_temp/src/Plugin/Field/FieldType/TintFieldType.php
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
  2 | ERROR | [x] Namespaced classes, interfaces and traits should not
    |       |     begin with a file doc comment
  3 | ERROR | [x] Doc comment short description must be on the first line
  4 | ERROR | [ ] Doc comment short description must be on a single line,
    |       |     further text should be a separate paragraph
 27 | ERROR | [x] Whitespace found at end of line
 44 | ERROR | [x] Whitespace found at end of line
 51 | ERROR | [x] Whitespace found at end of line
 54 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ewsh/pareview_temp/src/Plugin/Field/FieldFormatter/TintFormatter.php
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
  2 | ERROR | [x] Namespaced classes, interfaces and traits should not
    |       |     begin with a file doc comment
  3 | ERROR | [x] Doc comment short description must be on the first line
  4 | ERROR | [ ] Doc comment short description must be on a single line,
    |       |     further text should be a separate paragraph
 26 | ERROR | [x] Whitespace found at end of line
 50 | ERROR | [x] Whitespace found at end of line
 52 | ERROR | [x] Whitespace found at end of line
 54 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...pareviewsh/pareview_temp/src/Plugin/Field/FieldWidget/TintWidget.php
--------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
  2 | ERROR | [x] Namespaced classes, interfaces and traits should not
    |       |     begin with a file doc comment
  3 | ERROR | [x] Doc comment short description must be on the first line
  4 | ERROR | [ ] Doc comment short description must be on a single line,
    |       |     further text should be a separate paragraph
 26 | ERROR | [x] Whitespace found at end of line
 37 | ERROR | [x] Whitespace found at end of line
 40 | ERROR | [x] Whitespace found at end of line
 41 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Form/TintSettingsForm.php
--------------------------------------------------------------------------
FOUND 16 ERRORS AND 1 WARNING AFFECTING 17 LINES
--------------------------------------------------------------------------
   3 | ERROR   | [x] Namespaced classes, interfaces and traits should not
     |         |     begin with a file doc comment
  11 | ERROR   | [x] There must be one blank line after the last USE
     |         |     statement; 2 found;
  20 | ERROR   | [x] Whitespace found at end of line
  27 | ERROR   | [x] Whitespace found at end of line
  36 | ERROR   | [x] Whitespace found at end of line
  43 | ERROR   | [x] Whitespace found at end of line
  44 | ERROR   | [x] Missing function doc comment
  53 | ERROR   | [x] Whitespace found at end of line
  61 | ERROR   | [x] Whitespace found at end of line
  70 | ERROR   | [x] Whitespace found at end of line
  88 | ERROR   | [x] Whitespace found at end of line
  97 | ERROR   | [x] Whitespace found at end of line
 108 | ERROR   | [x] Whitespace found at end of line
 112 | WARNING | [ ] Possible useless method overriding detected
 115 | ERROR   | [x] Whitespace found at end of line
 121 | ERROR   | [x] Whitespace found at end of line
 131 | ERROR   | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/tint_connector.links.menu.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 4 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 825ms; Memory: 4Mb