http://git.drupal.org/project/translators

Primary tabs

Review of the 8.x-1.x branch (commit b99cfb3):
  • The translators_content.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: .../tests/src/Functional/TranslatorsContentTranslationWorkflowsTest.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     217 | WARNING | Unused variable $args.
    --------------------------------------------------------------------------
    
    Time: 4.45 secs; Memory: 8Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
  94 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
 113 | ERROR   | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/translators.install
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 30 | ERROR | Doc comment short description must be on a single line,
    |       | further text should be a separate paragraph
--------------------------------------------------------------------------


FILE: ..._temp/modules/translators_content/translators_content.links.task.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...rs_content/src/Handler/TranslatorsContentTranslationHandlerTrait.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
  27 | ERROR | [x] Parameter comment must end with a full stop
 170 | ERROR | [ ] Type hint "\Drupal\Core\Entity\EntityInterface"
     |       |     missing for $entity
 212 | ERROR | [ ] Type hint "\Drupal\Core\Entity\EntityInterface"
     |       |     missing for $entity
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ranslators_content/src/Controller/TranslatorsContentLanguageCtrl.php
--------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
  35 | ERROR | [ ] Type hint "\Drupal\Core\Form\FormStateInterface"
     |       |     missing for $form_state
  48 | ERROR | [ ] Type hint "\Drupal\Core\Form\FormStateInterface"
     |       |     missing for $form_state
 103 | ERROR | [x] Parameter comment must end with a full stop
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../translators_content/src/Controller/TranslatorsContentController.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------
  50 | ERROR   | [ ] Parameter $entity_field_manager is not described in
     |         |     comment
 197 | ERROR   | [x] Equals sign not aligned with surrounding
     |         |     assignments; expected 1 space but found 2 spaces
 336 | ERROR   | [x] Expected 1 space after "="; 2 found
 381 | ERROR   | [ ] Type hint
     |         |     "\Drupal\Core\Entity\ContentEntityInterface" missing
     |         |     for $entity
 381 | ERROR   | [ ] Type hint "\Drupal\Core\Language\LanguageInterface"
     |         |     missing for $language
 386 | WARNING | [ ] Only string literals should be passed to t() where
     |         |     possible
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...mp/modules/translators_content/src/TranslatorsContentPermissions.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 86 | ERROR | [x] Data types in @param tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...ors_content/tests/src/Functional/TranslationViewsIntegrationTest.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 20 | ERROR | [x] The closing brace for the class must have an empty line
    |       |     before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...drupal/pareviewsh/pareview_temp/src/Form/TranslatorsSettingsForm.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 162 | ERROR | [x] Equals sign not aligned with surrounding assignments;
     |       |     expected 1 space but found 2 spaces
 163 | ERROR | [x] Equals sign not aligned with surrounding assignments;
     |       |     expected 1 space but found 2 spaces
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 6.79 secs; Memory: 8Mb