http://git.drupal.org/project/vimeo_embed_field.git 8.x-1.x

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit ff1b650):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • ./vimeo_embed_field.module: All functions should be prefixed with your module/theme name (vimeo_embed_field) to avoid name clashes. See https://www.drupal.org/node/318#naming
    function _get_vimeo_id_from_vimeo_url($url = "") {
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...areview_temp/src/Plugin/Field/FieldFormatter/VimeoFieldFormatter.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     86 | WARNING | Avoid backslash escaping in translatable strings when
        |         | possible, use "" quotes instead
    --------------------------------------------------------------------------
    
    Time: 594ms; Memory: 6Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...areview_temp/src/Plugin/Field/FieldFormatter/VimeoThumbFormatter.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     116 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/vimeo_embed_field.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
     7 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
     8 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
     9 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    Time: 253ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.