https://git.drupal.org/project/access_by_entity.git

Primary tabs

Review of the 8.x-1.x branch (commit 08302ea):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The CONFIGURATION section is missing.
  • The access_by_entity.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...ewsh/pareview_temp/src/Plugin/Derivative/AccessByEntityLocalTask.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     58 | WARNING | Unused variable $access_load.
    --------------------------------------------------------------------------
    
    Time: 439ms; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/access_by_entity.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 12 | ERROR | [x] There must be one blank line after the last USE
    |       |     statement; 0 found;
 16 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/src/EntityTypeInfo.php
--------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
  44 | ERROR | Parameter $access_by_entity_storage is not described in
     |       | comment
  44 | ERROR | Parameter $entity_type_manager is not described in comment
  44 | ERROR | Parameter $config is not described in comment
 125 | ERROR | Parameter $entity is not described in comment
 144 | ERROR | Parameter $route_name is not described in comment
 155 | ERROR | Type hint "array" missing for $data
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/AccessByEntityStorage.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------
  95 | ERROR | [ ] Doc comment short description must be on a single
     |       |     line, further text should be a separate paragraph
  98 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
     |       |     4 spaces
 100 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
     |       |     4 spaces
 102 | ERROR | [x] Parameter comment indentation must be 3 spaces, found
     |       |     4 spaces
 104 | ERROR | [ ] Description for the @return value is missing
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...rupal/pareviewsh/pareview_temp/tests/src/Unit/AccessByEntityTest.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 6 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../vendor/drupal/pareviewsh/pareview_temp/access_by_entity.routing.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 8 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 910ms; Memory: 6Mb