https://git.drupal.org/project/advanced_link.git

Primary tabs

Git errors: Review of the 7.x-1.x branch (commit d294d4d):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The advanced_link.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
    
    FILE: ...1101/web/vendor/drupal/pareviewsh/pareview_temp/advanced_link.module
    --------------------------------------------------------------------------
    FOUND 4 ERRORS AFFECTING 4 LINES
    --------------------------------------------------------------------------
      49 | ERROR | [x] Whitespace found at end of line
      50 | ERROR | [x] Whitespace found at end of line
      95 | ERROR | [x] Inline comments must end in full-stops, exclamation
         |       |     marks, colons, question marks, or closing parentheses
     152 | ERROR | [x] Whitespace found at end of line
    --------------------------------------------------------------------------
    PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    --------------------------------------------------------------------------
    
    Time: 369ms; Memory: 6Mb
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...1101/web/vendor/drupal/pareviewsh/pareview_temp/advanced_link.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     332 | WARNING | Do not call theme functions directly, use
         |         | theme('link_field', ...) instead
    --------------------------------------------------------------------------
    
    Time: 196ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.