Revision of https://git.drupal.org/project/amp_carousel.git from Tue, 07/09/2019 - 21:30

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 7.x-1.x branch (commit d514878):
  • Remove "version" from the ./amp_carousel.info file, it will be added by drupal.org packaging automatically.
  • Remove "project" from the ./amp_carousel.info file, it will be added by drupal.org packaging automatically.
  • Remove "datestamp" from the ./amp_carousel.info file, it will be added by drupal.org packaging automatically.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...ite1101/web/vendor/drupal/pareviewsh/pareview_temp/amp_carousel.info
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
--------------------------------------------------------------------------


FILE: ...rupal/pareviewsh/pareview_temp/theme/views-view-amp-carousel.tpl.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
   |       |     line
 3 | ERROR | [x] Doc comment short description must be on the first line
 3 | ERROR | [x] Doc comment short description must start with a capital
   |       |     letter
 4 | ERROR | [ ] Doc comment short description must be on a single line,
   |       |     further text should be a separate paragraph
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 5 | WARNING | Line exceeds 80 characters; contains 84 characters
--------------------------------------------------------------------------


FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/amp_carousel.module
--------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------
  72 | WARNING | [ ] Line exceeds 80 characters; contains 86 characters
 145 | ERROR   | [ ] Concatenating translatable strings is not allowed,
     |         |     use placeholders instead and only one string literal
 289 | ERROR   | [x] Whitespace found at end of line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/amp_carousel_style_plugin.inc
--------------------------------------------------------------------------
FOUND 53 ERRORS AFFECTING 50 LINES
--------------------------------------------------------------------------
 11 | ERROR | [ ] Class name must begin with a capital letter
 11 | ERROR | [ ] Class name must use UpperCamel naming without
    |       |     underscores
 13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 16 | ERROR | [ ] Public method name
    |       |     "amp_carousel_style_plugin::option_definition" is not
    |       |     in lowerCamel format
 17 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 19 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 20 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 21 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 22 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 24 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 32 | ERROR | [ ] Public method name
    |       |     "amp_carousel_style_plugin::options_form" is not in
    |       |     lowerCamel format
 33 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 36 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 37 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 38 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 39 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 41 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 42 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 43 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 44 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 45 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 48 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 49 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 50 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 51 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 52 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 53 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 56 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 57 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 58 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 59 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 60 | ERROR | [x] Array indentation error, expected 14 spaces but found
    |       |     16
 61 | ERROR | [x] Array indentation error, expected 18 spaces but found
    |       |     16
 65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 66 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 67 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 68 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 69 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 71 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 72 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 73 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 74 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 75 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 49 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 867ms; Memory: 6Mb