Revision of https://git.drupal.org/project/amp_carousel.git from Wed, 05/15/2019 - 22:58

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 7.x-1.x branch (commit 2729737):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Remove "version" from the ./amp_carousel.info file, it will be added by drupal.org packaging automatically.
  • Remove "project" from the ./amp_carousel.info file, it will be added by drupal.org packaging automatically.
  • Remove "datestamp" from the ./amp_carousel.info file, it will be added by drupal.org packaging automatically.
  • The amp_carousel.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/amp_carousel.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     177 | WARNING | #options values usually have to run through t() for
         |         | translation
     183 | WARNING | #options values usually have to run through t() for
         |         | translation
    --------------------------------------------------------------------------
    
    
    FILE: ...vendor/drupal/pareviewsh/pareview_temp/amp_carousel_style_plugin.inc
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     32 | WARNING | #options values usually have to run through t() for
        |         | translation
     38 | WARNING | #options values usually have to run through t() for
        |         | translation
    --------------------------------------------------------------------------
    
    Time: 373ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...ite1101/web/vendor/drupal/pareviewsh/pareview_temp/amp_carousel.info
--------------------------------------------------------------------------
FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added by
   |         | drupal.org packaging automatically
 1 | ERROR   | Duplicate entry for "core" in info file
 8 | ERROR   | It's only necessary to declare files[] if they declare a
   |         | class or interface.
 9 | ERROR   | It's only necessary to declare files[] if they declare a
   |         | class or interface.
--------------------------------------------------------------------------


FILE: .../vendor/drupal/pareviewsh/pareview_temp/theme/amp_carousel.theme.inc
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 5 | ERROR | [x] Doc comment short description must end with a full stop
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...rupal/pareviewsh/pareview_temp/theme/views-view-amp-carousel.tpl.php
--------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
  3 | ERROR | [x] Doc comment short description must be on the first line
  3 | ERROR | [x] Doc comment short description must start with a capital
    |       |     letter
  4 | ERROR | [ ] Doc comment short description must be on a single line,
    |       |     further text should be a separate paragraph
 11 | ERROR | [x] Concat operator must be surrounded by a single space
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
  4 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
 16 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/amp_carousel.views.inc
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
   |       |     line
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...e1101/web/vendor/drupal/pareviewsh/pareview_temp/amp_carousel.module
--------------------------------------------------------------------------
FOUND 19 ERRORS AND 2 WARNINGS AFFECTING 17 LINES
--------------------------------------------------------------------------
   5 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
  70 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
  70 | ERROR   | [x] Expected 1 space after closing parenthesis; found 0
  71 | ERROR   | [x] Inline comments must start with a capital letter
  72 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
  72 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  74 | ERROR   | [x] Expected 1 space after IF keyword; 0 found
  74 | ERROR   | [x] Expected 1 space after closing parenthesis; found 0
  75 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  90 | ERROR   | [x] Concat operator must be surrounded by a single space
  93 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 141 | ERROR   | [ ] Concatenating translatable strings is not allowed,
     |         |     use placeholders instead and only one string literal
 141 | ERROR   | [ ] If the line declaring an array spans longer than 80
     |         |     characters, each element should be broken into its
     |         |     own line
 163 | ERROR   | [x] Functions must not contain multiple empty lines in a
     |         |     row; found 2 empty lines
 164 | ERROR   | [x] Whitespace found at end of line
 217 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 236 | ERROR   | [x] Doc comment short description must end with a full
     |         |     stop
 237 | ERROR   | [x] There must be exactly one blank line before the tags
     |         |     in a doc comment
 244 | ERROR   | [x] Expected 1 space after "=>"; 0 found
 245 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: 'async'
 249 | ERROR   | [x] Expected 1 blank line after function; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 18 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/amp_carousel_style_plugin.inc
--------------------------------------------------------------------------
FOUND 40 ERRORS AND 1 WARNING AFFECTING 35 LINES
--------------------------------------------------------------------------
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one
    |         |     blank line
  7 | ERROR   | [x] Missing class doc comment
  7 | ERROR   | [ ] Class name must begin with a capital letter
  7 | ERROR   | [ ] Class name must use UpperCamel naming without
    |         |     underscores
 11 | ERROR   | [x] Visibility must be declared on method
    |         |     "option_definition"
 11 | ERROR   | [ ] Method name
    |         |     "amp_carousel_style_plugin::option_definition" is not
    |         |     in lowerCamel format
 11 | ERROR   | [x] Expected 1 blank line before function; 0 found
 24 | ERROR   | [x] Visibility must be declared on method "options_form"
 24 | ERROR   | [x] Missing function doc comment
 24 | ERROR   | [ ] Method name "amp_carousel_style_plugin::options_form"
    |         |     is not in lowerCamel format
 27 | WARNING | [ ] The use of function dsm() is discouraged
 30 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 31 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 32 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 33 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 36 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 37 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 38 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 39 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 42 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 43 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 44 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 45 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 46 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 47 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 50 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     4
 51 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 52 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 53 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 54 | ERROR   | [x] Array indentation error, expected 10 spaces but found
    |         |     12
 55 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     12
 60 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 61 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 62 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 63 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 66 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 67 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 68 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 69 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 71 | ERROR   | [x] Expected 1 blank line after function; 0 found
 72 | ERROR   | [x] The closing brace for the class must have an empty
    |         |     line before it
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 36 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 865ms; Memory: 6Mb