https://git.drupal.org/project/apachesolr_term.git

Primary tabs

Git errors: Review of the 7.x-1.x branch (commit 8f6b67e):
  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • The apachesolr_term.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Remove all old CVS $Id tags, they are not needed anymore.
    apachesolr_term.install:2:// $Id$
    apachesolr_term.module:2:// $Id$
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/apachesolr_term.install
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     2 | WARNING | There must be no blank line following an inline comment
    --------------------------------------------------------------------------
    
    
    FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/apachesolr_term.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
    --------------------------------------------------------------------------
       2 | WARNING | There must be no blank line following an inline comment
      35 | WARNING | Unused variable $tt.
      82 | WARNING | Unused variable $insert.
     106 | WARNING | There must be no blank line following an inline comment
    --------------------------------------------------------------------------
    
    Time: 132ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/apachesolr_term.install
--------------------------------------------------------------------------
FOUND 11 ERRORS AND 1 WARNING AFFECTING 10 LINES
--------------------------------------------------------------------------
  1 | ERROR   | [x] The PHP open tag must be followed by exactly one
    |         |     blank line
  2 | WARNING | [x] There must be no blank line following an inline
    |         |     comment
  2 | ERROR   | [x] You must use "/**" style comments for a file comment
  2 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
  6 | ERROR   | [x] Function comment short description must start with
    |         |     exactly one space
 14 | ERROR   | [x] Array indentation error, expected 4 spaces but found
    |         |     6
 18 | ERROR   | [ ] Do not use t() in hook_schema(), this will only
    |         |     generate overhead for translators
 21 | ERROR   | [ ] Do not use t() in hook_schema(), this will only
    |         |     generate overhead for translators
 27 | ERROR   | [ ] Do not use t() in hook_schema(), this will only
    |         |     generate overhead for translators
 33 | ERROR   | [ ] Do not use t() in hook_schema(), this will only
    |         |     generate overhead for translators
 39 | ERROR   | [ ] Do not use t() in hook_schema(), this will only
    |         |     generate overhead for translators
 45 | ERROR   | [ ] Do not use t() in hook_schema(), this will only
    |         |     generate overhead for translators
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...01/web/vendor/drupal/pareviewsh/pareview_temp/apachesolr_term.module
--------------------------------------------------------------------------
FOUND 12 ERRORS AND 3 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------
   1 | ERROR   | [x] The PHP open tag must be followed by exactly one
     |         |     blank line
   2 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
   2 | ERROR   | [x] You must use "/**" style comments for a file comment
   2 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
   6 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
   6 | ERROR   | [x] Function comment short description must start with
     |         |     exactly one space
   9 | ERROR   | [x] Missing function doc comment
  22 | ERROR   | [x] Expected "object" but found "stdClass" for parameter
     |         |     type
  22 | ERROR   | [ ] Doc comment for parameter $entity does not match
     |         |     actual variable name $entity_type
  47 | ERROR   | [x] 2 spaces found before inline comment; expected "//
     |         |     Generic usecase for future reference. Callbacks can"
     |         |     but found "//  Generic usecase for future reference.
     |         |     Callbacks can"
  48 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  86 | ERROR   | [x] No space found before comment text; expected "//
     |         |     drupal_set_message($e->getMessage(), 'error');" but
     |         |     found "//drupal_set_message($e->getMessage(),
     |         |     'error');"
  86 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
  95 | ERROR   | [x] Missing function doc comment
 106 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 257ms; Memory: 4Mb