https://git.drupal.org/project/bg_img_field.git

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit 771eb46):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • Remove all .DS_Store files from your repository.
  • The bg_img_field.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...sh/pareview_temp/src/Plugin/Field/FieldWidget/BgImageFieldWidget.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     100 | WARNING | #description values usually have to run through t() for
         |         | translation
    --------------------------------------------------------------------------
    
    Time: 816ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
 23 | WARNING | Line exceeds 80 characters; contains 112 characters
 24 | WARNING | Line exceeds 80 characters; contains 84 characters
 25 | WARNING | Line exceeds 80 characters; contains 98 characters
--------------------------------------------------------------------------


FILE: ...rupal/pareviewsh/pareview_temp/config/schema/bg_img_field.schema.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 28 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 1.6 secs; Memory: 6Mb