Revision of https://git.drupal.org/project/block_style_plugins.git from Thu, 12/06/2018 - 16:42

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit d927808):
  • Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • The block_style_plugins_test.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...eb/vendor/drupal/pareviewsh/pareview_temp/block_style_plugins.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     84 | WARNING | Unused variable $name.
    --------------------------------------------------------------------------
    
    
    FILE: ...s/modules/block_style_plugins_test/block_style_plugins_test.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
     7 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
     8 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
     9 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    
    FILE: .../vendor/drupal/pareviewsh/pareview_temp/block_style_plugins.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     8 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
     9 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    Time: 1.69 secs; Memory: 6Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
 74 | WARNING | Line exceeds 80 characters; contains 88 characters
 87 | WARNING | Line exceeds 80 characters; contains 82 characters
--------------------------------------------------------------------------


FILE: ...r/drupal/pareviewsh/pareview_temp/src/Plugin/BlockStyleInterface.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 52 | ERROR | Type hint "array" missing for $form
--------------------------------------------------------------------------


FILE: ...vendor/drupal/pareviewsh/pareview_temp/src/Plugin/BlockStyleBase.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
 104 | WARNING | Line exceeds 80 characters; contains 82 characters
 259 | WARNING | Line exceeds 80 characters; contains 95 characters
--------------------------------------------------------------------------


FILE: ...ock_style_plugins_test/src/Plugin/BlockStyle/CheckboxWithExclude.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 33 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
 33 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 3.18 secs; Memory: 6Mb