Revision of https://git.drupal.org/project/bulkcckfielddelete.git from Mon, 04/01/2019 - 12:55

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Git errors: Review of the 7.x-1.x branch (commit 0fc5064):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The INTRODUCTION section is missing.
    • The REQUIREMENTS section is missing.
    • The INSTALLATION section is missing.
    • The CONFIGURATION section is missing.
  • ./bulkcckfielddelete.module: All functions should be prefixed with your module/theme name (bulkcckfielddelete) to avoid name clashes. See https://www.drupal.org/node/318#naming
    function bulk_cck_field_delete_permission() {
    function bulk_cck_field_delete_menu() {
    function cck_bulk_field_delete_form($form, &$form_state) {
    function cck_bulk_field_delete_form_submit($form_id, &$form_state) {
    
  • The bulkcckfielddelete.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/bulkcckfielddelete.module
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
     45 | WARNING | Unused variable $key.
     76 | WARNING | Unused variable $key.
     81 | WARNING | Unused variable $field_cleanup.
    --------------------------------------------------------------------------
    
    Time: 233ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/bulkcckfielddelete.module
--------------------------------------------------------------------------
FOUND 11 ERRORS AND 1 WARNING AFFECTING 9 LINES
--------------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment
 30 | ERROR   | [x] Doc comment short description must start with a
    |         |     capital letter
 43 | ERROR   | [x] Comments may not appear after statements
 44 | ERROR   | [x] Comments may not appear after statements
 44 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
 54 | ERROR   | [x] No space found before comment text; expected "//
    |         |     $options = asort($instance);" but found "//$options =
    |         |     asort($instance);"
 56 | WARNING | [ ] Only string literals should be passed to t() where
    |         |     possible
 70 | ERROR   | [x] Doc comment short description must start with a
    |         |     capital letter
 74 | ERROR   | [x] Comments may not appear after statements
 74 | ERROR   | [x] Inline comments must start with a capital letter
 74 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
 78 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 11 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------
  2 | WARNING | [ ] Line exceeds 80 characters; contains 321 characters
 12 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
 18 | ERROR   | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/bulkcckfielddelete.info
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 4 | ERROR | [x] Expected 1 newline at end of file; 5 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 721ms; Memory: 4Mb