https://git.drupal.org/project/bulkemail.git --branch 8.x-1.x

Primary tabs

Review of the --branch branch (commit cca2de3):
  • Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
    • The REQUIREMENTS section is missing.
  • The bulkemail.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
  • Bad line endings were found, always use unix style terminators. See https://www.drupal.org/coding-standards#indenting
    ./src/Form/MailForm.php:     PHP script, ASCII text, with CRLF line terminators
    ./bulkemail.info.yml:        ASCII text, with CRLF line terminators
    ./bulkemail.routing.yml:     ASCII text, with CRLF line terminators
    bulkemail.info.yml
    bulkemail.routing.yml
    src/Form/MailForm.php
    
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/src/Form/MailForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
    --------------------------------------------------------------------------
      30 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      31 | WARNING | User::load calls should be avoided in classes, use
         |         | dependency injection instead
      38 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     100 | WARNING | Unused variable $email_from.
     102 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     107 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     114 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
     116 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     118 | WARNING | There must be no blank line following an inline comment
     121 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
    --------------------------------------------------------------------------
    
    Time: 237ms; Memory: 4Mb
    
  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 1 ERROR AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------
 19 | WARNING | [ ] Line exceeds 80 characters; contains 101 characters
 20 | WARNING | [ ] Line exceeds 80 characters; contains 171 characters
 21 | WARNING | [ ] Line exceeds 80 characters; contains 159 characters
 35 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
 42 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 42 | ERROR   | [x] Expected 1 newline at end of file; 3 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/src/Form/MailForm.php
--------------------------------------------------------------------------
FOUND 83 ERRORS AND 7 WARNINGS AFFECTING 76 LINES
--------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but
     |         |     found "\r\n"
   3 | ERROR   | [x] Namespaced classes, interfaces and traits should not
     |         |     begin with a file doc comment
  12 | WARNING | [x] Unused use statement
  19 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  22 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  23 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  24 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  26 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  29 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  30 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  31 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  31 | ERROR   | [x] Namespaced classes/interfaces/traits should be
     |         |     referenced with use statements
  32 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  33 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  35 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  35 | ERROR   | [x] Short array syntax must be used to define arrays
  38 | WARNING | [ ] Translatable strings must not begin or end with
     |         |     white spaces, use placeholders with t() for
     |         |     variables
  39 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: TRUE
  41 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  41 | ERROR   | [x] Short array syntax must be used to define arrays
  44 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: TRUE
  46 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  46 | ERROR   | [x] Short array syntax must be used to define arrays
  49 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: TRUE
  51 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  51 | ERROR   | [x] Short array syntax must be used to define arrays
  55 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: ''
  57 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  57 | ERROR   | [x] Short array syntax must be used to define arrays
  61 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: ''
  63 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  63 | ERROR   | [x] Short array syntax must be used to define arrays
  64 | ERROR   | [x] Array indentation error, expected 10 spaces but
     |         |     found 12
  65 | ERROR   | [x] Array indentation error, expected 10 spaces but
     |         |     found 12
  66 | ERROR   | [x] Array indentation error, expected 10 spaces but
     |         |     found 12
  68 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  69 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  71 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  74 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  75 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  76 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  77 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  78 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     12
  79 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  80 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  81 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     12
  82 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  83 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  84 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     12
  85 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  86 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  87 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     12
  88 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  89 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  91 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  94 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
  95 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  96 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  97 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  98 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
  99 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 100 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 102 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 103 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 104 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 104 | ERROR   | [x] Comments may not appear after statements
 104 | ERROR   | [x] Inline comments must end in full-stops, exclamation
     |         |     marks, colons, question marks, or closing
     |         |     parentheses
 105 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 106 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 107 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 108 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 108 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "TRUE" but found "true"
 109 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 109 | ERROR   | [x] PHP keywords must be lowercase; expected "as" but
     |         |     found "AS"
 110 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     12
 111 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 111 | ERROR   | [x] Inline comments must start with a capital letter
 112 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 112 | ERROR   | [x] No space found before comment text; expected "//
     |         |     Check result sucess or not." but found "//Check
     |         |     result sucess or not."
 113 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 113 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected
     |         |     "TRUE" but found "true"
 114 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     12
 115 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     12
 116 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     12
 117 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found
     |         |     12
 118 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 119 | ERROR   | [x] Functions must not contain multiple empty lines in a
     |         |     row; found 2 empty lines
 121 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found
     |         |     8
 122 | ERROR   | [x] Whitespace found at end of line
 123 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found
     |         |     4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 89 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...web/vendor/drupal/pareviewsh/pareview_temp/bulkemail.permissions.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 4 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/bulkemail.info.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 5 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...site1101/web/vendor/drupal/pareviewsh/pareview_temp/bulkemail.module
--------------------------------------------------------------------------
FOUND 14 ERRORS AND 2 WARNINGS AFFECTING 14 LINES
--------------------------------------------------------------------------
  1 | ERROR   | [x] Missing file doc comment
  3 | WARNING | [x] Unused use statement
  4 | WARNING | [x] Unused use statement
  8 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
  9 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
 11 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 11 | ERROR   | [x] Short array syntax must be used to define arrays
 15 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 16 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 3
 17 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 5
 18 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 5
 19 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 5
 19 | ERROR   | [x] Short array syntax must be used to define arrays
 20 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 5
 22 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 1
 23 | ERROR   | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 16 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/bulkemail.routing.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 7 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/bulkemail.links.menu.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 480ms; Memory: 4Mb