Revision of https://git.drupal.org/project/cg_payment.git from Fri, 01/11/2019 - 07:51

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 46238ad):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • No automated test cases were found, did you consider writing PHPUnit tests? This is not a requirement but encouraged for professional software development.
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 64 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/src/Manager/RequestManager.php
--------------------------------------------------------------------------
FOUND 21 ERRORS AFFECTING 15 LINES
--------------------------------------------------------------------------
  20 | ERROR | [x] Doc comment short description must end with a full
     |       |     stop
  21 | ERROR | [x] There must be exactly one blank line before the tags
     |       |     in a doc comment
  33 | ERROR | [ ] Missing short description in doc comment
  38 | ERROR | [ ] Missing short description in doc comment
  43 | ERROR | [ ] Missing short description in doc comment
 101 | ERROR | [ ] Missing short description in doc comment
 128 | ERROR | [x] Inline comments must end in full-stops, exclamation
     |       |     marks, colons, question marks, or closing parentheses
 153 | ERROR | [ ] Inline doc block comments are not allowed; use "/*
     |       |     Comment */" or "// Comment" instead
 185 | ERROR | [ ] Missing short description in doc comment
 243 | ERROR | [ ] Missing parameter comment
 244 | ERROR | [x] Separate the @param and @return sections by a blank
     |       |     line.
 244 | ERROR | [ ] Description for the @return value is missing
 244 | ERROR | [x] Data types in @return tags need to be fully namespaced
 254 | ERROR | [ ] Missing parameter comment
 255 | ERROR | [x] Separate the @param and @return sections by a blank
     |       |     line.
 255 | ERROR | [ ] Description for the @return value is missing
 255 | ERROR | [x] Data types in @return tags need to be fully namespaced
 265 | ERROR | [ ] Missing parameter comment
 266 | ERROR | [x] Separate the @param and @return sections by a blank
     |       |     line.
 266 | ERROR | [ ] Description for the @return value is missing
 266 | ERROR | [x] Data types in @return tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/src/CgChargeEvent.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
 34 | ERROR | Missing parameter comment
 35 | ERROR | Missing parameter comment
--------------------------------------------------------------------------


FILE: ...dor/drupal/pareviewsh/pareview_temp/src/Utility/TransactionTrait.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
 20 | ERROR   | Return type "\Drupal\cg_payment\TransactionInterface |
    |         | bool" must not contain spaces
 21 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------


FILE: ...wsh/pareview_temp/src/Plugin/Validation/Constraint/ValidTerminal.php
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
  1 | ERROR | [x] The PHP open tag must be followed by exactly one blank
    |       |     line
 23 | ERROR | [ ] Class property $terminal_id_field_name should use
    |       |     lowerCamel naming without underscores
 30 | ERROR | [ ] Class property $mid_field_name should use lowerCamel
    |       |     naming without underscores
 32 | ERROR | [ ] Missing short description in doc comment
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...upal/pareviewsh/pareview_temp/src/Controller/PaymentCompletePage.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 64 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------


FILE: .../web/vendor/drupal/pareviewsh/pareview_temp/src/RequestInterface.php
--------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------
 13 | ERROR | [x] There must be exactly one blank line before the tags in
    |       |     a doc comment
 18 | ERROR | [x] Parameter comment must end with a full stop
 22 | ERROR | [x] Parameter comment must end with a full stop
 28 | ERROR | [ ] Description for the @return value is missing
 30 | ERROR | [x] Expected 1 blank line before function; 0 found
 30 | ERROR | [x] Expected 1 blank line after function; 2 found
 47 | ERROR | [ ] Return type "string | null" must not contain spaces
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...te1101/web/vendor/drupal/pareviewsh/pareview_temp/cg_payment.api.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 10 | ERROR | Doc comment short description must be on a single line,
    |       | further text should be a separate paragraph
--------------------------------------------------------------------------

Time: 2.23 secs; Memory: 6Mb