https://git.drupal.org/project/chatbot_api.git

Primary tabs

Git errors: Review of the 8.x-1.x branch (commit bffec07):
  • README.md or README.txt is missing, see the guidelines for in-project documentation.
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ..._temp/modules/chatbot_api_entities/src/Form/EntityCollectionForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
    --------------------------------------------------------------------------
     344 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     345 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     346 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     347 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     348 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: .../modules/chatbot_api_alexa/src/EventSubscriber/RequestSubscriber.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     35 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: .../modules/chatbot_api_apiai/src/EventSubscriber/RequestSubscriber.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     35 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...i_helloworld_intent_test/chatbot_api_helloworld_intent_test.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    --------------------------------------------------------------------------
     8 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    
    FILE: ...chatbot_api_views_intent_test/chatbot_api_views_intent_test.info.yml
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    --------------------------------------------------------------------------
     8 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
     9 | WARNING | All dependencies must be prefixed with the project name,
       |         | for example "drupal:"
    --------------------------------------------------------------------------
    
    Time: 1.43 secs; Memory: 6Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...mp/modules/chatbot_api_entities/src/Plugin/QueryHandlerInterface.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 27 | ERROR | Arguments with default values must be at the end of the
    |       | argument list
--------------------------------------------------------------------------


FILE: ...ntities/src/Plugin/ChatbotApiEntities/QueryHandler/DefaultEntity.php
--------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------
  5 | WARNING | [x] Unused use statement
 37 | ERROR   | [ ] Arguments with default values must be at the end of
    |         |     the argument list
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...iew_temp/modules/chatbot_api_entities/src/Plugin/PushHandlerBase.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 101 | WARNING | Empty return statement not required here
--------------------------------------------------------------------------


FILE: ...i_entities/tests/src/Functional/ChatbotApiEntitiesFunctionalTest.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 48 | ERROR | Public method name
    |       | "ChatbotApiEntitiesFunctionalTest::testAdminUI" is not in
    |       | lowerCamel format
--------------------------------------------------------------------------


FILE: ...sh/pareview_temp/src/Command/Generate/PluginChatbotIntentCommand.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 16 | WARNING | [x] Unused use statement
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 2.79 secs; Memory: 8Mb