Revision of https://git.drupal.org/project/ckeditor_content_style.git from Tue, 02/19/2019 - 22:43

Revisions allow you to track differences between multiple versions of your content, and revert back to older versions.

Review of the 8.x-1.x branch (commit 98a42d4):
  • Coder Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.
  • ESLint has found some issues with your code (please check the JavaScript coding standards).
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 55, col 11, Error - Expected an assignment or function call and instead saw an expression. (no-unused-expressions)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 126, col 7, Warning - JSDoc syntax error. (valid-jsdoc)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 151, col 9, Warning - Missing JSDoc @return for function. (valid-jsdoc)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 177, col 9, Warning - Missing JSDoc for parameter 'domRange'. (valid-jsdoc)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 304, col 11, Error - Split 'var' declarations into multiple statements. (one-var)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 370, col 11, Error - Unexpected constant condition. (no-constant-condition)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 467, col 20, Error - Avoid arguments.callee. (no-caller)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 499, col 15, Error - 'selection' used outside of binding context. (block-scoped-var)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 692, col 21, Error - Properties shouldn't be quoted as all quotes are redundant. (quote-props)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 699, col 21, Error - Properties shouldn't be quoted as all quotes are redundant. (quote-props)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 725, col 17, Error - 'txttofind' used outside of binding context. (block-scoped-var)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 728, col 17, Error - 'txttofind' used outside of binding context. (block-scoped-var)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 733, col 35, Error - 'txttofind' used outside of binding context. (block-scoped-var)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 739, col 17, Error - 'txttofind' is already defined. (no-redeclare)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 739, col 17, Error - 'txttofind' used outside of binding context. (block-scoped-var)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 742, col 34, Error - 'txttofind' used outside of binding context. (block-scoped-var)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 745, col 17, Error - 'txttofind' used outside of binding context. (block-scoped-var)
    /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 750, col 62, Error - 'txttofind' used outside of binding context. (block-scoped-var)
    
    18 problems
    
  • DrupalPractice has found some issues with your code, but could be false positives.
    
    FILE: ...drupal/pareviewsh/pareview_temp/src/Controller/DefaultController.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
    --------------------------------------------------------------------------
     62 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     63 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
     76 | WARNING | \Drupal calls should be avoided in classes, use
        |         | dependency injection instead
    --------------------------------------------------------------------------
    
    
    FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/src/Form/CkCSForm.php
    --------------------------------------------------------------------------
    FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
    --------------------------------------------------------------------------
      49 | WARNING | t() calls should be avoided in classes, use dependency
         |         | injection and $this->t() instead
      84 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
      89 | WARNING | Messages are user facing text and must run through t()
         |         | for translation
      97 | WARNING | \Drupal calls should be avoided in classes, use
         |         | dependency injection instead
     101 | WARNING | Messages are user facing text and must run through t()
         |         | for translation
    --------------------------------------------------------------------------
    
    Time: 438ms; Memory: 4Mb
    
This automated report was generated with PAReview.sh, your friendly project application review script.

FILE: ...00000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/README.txt
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------
  6 | WARNING | Line exceeds 80 characters; contains 93 characters
 11 | WARNING | Line exceeds 80 characters; contains 93 characters
 16 | WARNING | Line exceeds 80 characters; contains 106 characters
 17 | WARNING | Line exceeds 80 characters; contains 100 characters
--------------------------------------------------------------------------


FILE: ...endor/drupal/pareviewsh/pareview_temp/ckeditor_content_style.install
--------------------------------------------------------------------------
FOUND 33 ERRORS AND 1 WARNING AFFECTING 27 LINES
--------------------------------------------------------------------------
  5 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
 12 | ERROR   | [x] Opening brace should be on the same line as the
    |         |     declaration
 13 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 13 | ERROR   | [x] Short array syntax must be used to define arrays
 14 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 15 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 15 | ERROR   | [x] Short array syntax must be used to define arrays
 16 | ERROR   | [x] Array indentation error, expected 10 spaces but found
    |         |     12
 16 | ERROR   | [x] Short array syntax must be used to define arrays
 17 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 18 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 19 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 21 | ERROR   | [x] Array indentation error, expected 10 spaces but found
    |         |     12
 21 | ERROR   | [x] Short array syntax must be used to define arrays
 22 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 23 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 24 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 25 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 27 | ERROR   | [x] Array indentation error, expected 10 spaces but found
    |         |     12
 27 | ERROR   | [x] Short array syntax must be used to define arrays
 28 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 29 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 30 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 31 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 33 | ERROR   | [x] Array indentation error, expected 10 spaces but found
    |         |     12
 33 | ERROR   | [x] Short array syntax must be used to define arrays
 34 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 35 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 36 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 37 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 38 | ERROR   | [x] Array indentation error, expected 14 spaces but found
    |         |     16
 41 | ERROR   | [x] Array indentation error, expected 6 spaces but found
    |         |     8
 41 | ERROR   | [x] Short array syntax must be used to define arrays
 43 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 33 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...1/web/vendor/drupal/pareviewsh/pareview_temp/src/Tests/CkcsTests.php
--------------------------------------------------------------------------
FOUND 28 ERRORS AFFECTING 24 LINES
--------------------------------------------------------------------------
 13 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 20 | ERROR | [ ] If the line declaring an array spans longer than 80
    |       |     characters, each element should be broken into its own
    |       |     line
 20 | ERROR | [x] Short array syntax must be used to define arrays
 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 33 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 34 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 35 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 35 | ERROR | [x] Short array syntax must be used to define arrays
 36 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 38 | ERROR | [x] Expected 1 blank line after function; 2 found
 41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 45 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 46 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 50 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 53 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 54 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 55 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 27 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: .../pareviewsh/pareview_temp/src/Plugin/CKEditorPlugin/StyleContent.php
--------------------------------------------------------------------------
FOUND 39 ERRORS AFFECTING 39 LINES
--------------------------------------------------------------------------
 18 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 24 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 26 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 27 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 35 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 36 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 43 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 44 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 51 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 52 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 59 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 61 | ERROR | [x] Array indentation error, expected 10 spaces but found
    |       |     12
 62 | ERROR | [x] Array indentation error, expected 14 spaces but found
    |       |     16
 63 | ERROR | [x] Array indentation error, expected 14 spaces but found
    |       |     16
 66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 72 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
 79 | ERROR | [x] Opening brace should be on the same line as the
    |       |     declaration
 80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
 81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 39 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------


FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/src/Form/CkCSForm.php
--------------------------------------------------------------------------
FOUND 12 ERRORS AND 1 WARNING AFFECTING 10 LINES
--------------------------------------------------------------------------
  8 | WARNING | [x] Unused use statement
 19 | ERROR   | [x] Expected 1 blank line before function; 0 found
 29 | ERROR   | [x] Short array syntax must be used to define arrays
 40 | ERROR   | [x] Short array syntax must be used to define arrays
 46 | ERROR   | [x] Short array syntax must be used to define arrays
 52 | ERROR   | [x] Short array syntax must be used to define arrays
 75 | ERROR   | [x] Comments may not appear after statements
 75 | ERROR   | [x] No space found before comment text; expected "//
    |         |     serialize value to save in database" but found
    |         |     "//serialize value to save in database"
 75 | ERROR   | [x] Inline comments must start with a capital letter
 75 | ERROR   | [x] Inline comments must end in full-stops, exclamation
    |         |     marks, colons, question marks, or closing parentheses
 79 | ERROR   | [x] Short array syntax must be used to define arrays
 91 | ERROR   | [x] Expected newline after closing brace
 92 | ERROR   | [x] Short array syntax must be used to define arrays
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

Time: 951ms; Memory: 4Mb