Skip to main content
PAReview
Toggle navigation
Home
All reviews
Review a Drupal project online
https://git.drupal.org/project/ckeditor_content_style.git
Primary tabs
View
Source
(active tab)
Revisions
Repeat review
HTML Source
Review of the 8.x-1.x branch (commit b502d01): <ul> <li><a href="http://eslint.org/">ESLint</a> has found some issues with your code (please check the <a href="https://www.drupal.org/node/172169">JavaScript coding standards</a>). <code> /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 55, col 11, Error - Expected an assignment or function call and instead saw an expression. (no-unused-expressions) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 126, col 7, Warning - JSDoc syntax error. (valid-jsdoc) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 151, col 9, Warning - Missing JSDoc @return for function. (valid-jsdoc) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 177, col 9, Warning - Missing JSDoc for parameter 'domRange'. (valid-jsdoc) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 304, col 11, Error - Split 'var' declarations into multiple statements. (one-var) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 370, col 11, Error - Unexpected constant condition. (no-constant-condition) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 467, col 20, Error - Avoid arguments.callee. (no-caller) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 499, col 15, Error - 'selection' used outside of binding context. (block-scoped-var) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 692, col 21, Error - Properties shouldn't be quoted as all quotes are redundant. (quote-props) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 699, col 21, Error - Properties shouldn't be quoted as all quotes are redundant. (quote-props) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 725, col 17, Error - 'txttofind' used outside of binding context. (block-scoped-var) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 728, col 17, Error - 'txttofind' used outside of binding context. (block-scoped-var) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 733, col 35, Error - 'txttofind' used outside of binding context. (block-scoped-var) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 739, col 17, Error - 'txttofind' is already defined. (no-redeclare) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 739, col 17, Error - 'txttofind' used outside of binding context. (block-scoped-var) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 742, col 34, Error - 'txttofind' used outside of binding context. (block-scoped-var) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 745, col 17, Error - 'txttofind' used outside of binding context. (block-scoped-var) /var/vhosts/c214000000/site1101/web/vendor/drupal/pareviewsh/pareview_temp/plugins/ckcs/dialogs/ckcs.js: line 750, col 62, Error - 'txttofind' used outside of binding context. (block-scoped-var) 18 problems </code></li> <li><a href="https://www.drupal.org/project/drupalpractice">DrupalPractice</a> has found some issues with your code, but could be false positives. <code> FILE: ...drupal/pareviewsh/pareview_temp/src/Controller/DefaultController.php -------------------------------------------------------------------------- FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES -------------------------------------------------------------------------- 62 | WARNING | \Drupal calls should be avoided in classes, use | | dependency injection instead 63 | WARNING | \Drupal calls should be avoided in classes, use | | dependency injection instead 76 | WARNING | \Drupal calls should be avoided in classes, use | | dependency injection instead -------------------------------------------------------------------------- FILE: ...101/web/vendor/drupal/pareviewsh/pareview_temp/src/Form/CkCSForm.php -------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------- 89 | WARNING | Messages are user facing text and must run through t() | | for translation 102 | WARNING | Messages are user facing text and must run through t() | | for translation -------------------------------------------------------------------------- Time: 431ms; Memory: 4Mb </code></li> </ul> <i>This automated report was generated with <a href="https://www.drupal.org/project/pareviewsh">PAReview.sh</a>, your friendly project application review script.</i>